[PR #1268] [MERGED] fix: download audit log certificate #1522

Closed
opened 2026-02-26 19:33:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1268
Author: @catalinpit
Created: 8/6/2024
Status: Merged
Merged: 8/9/2024
Merged by: @Mythie

Base: mainHead: fix/audit-log-download


📝 Commits (8)

  • 06e3750 fix: download audit log certificate
  • eb5f562 fix: dld audit log of doc uploaded by another team user and not the personal doc upld by another usr
  • 495c5d4 fix: make document uploader it optional
  • bac978c fix: make document uploader id optional
  • 103a768 fix: fix typo
  • 38a2b8d fix: avoid access to unauthorized audit logs
  • e6af278 fix: typo
  • 5b18ca9 fix: tidy implementaiton

📊 Changes

4 files changed (+23 additions, -5 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/logs/download-audit-log-button.tsx (+7 -2)
📝 packages/trpc/server/document-router/router.ts (+10 -2)
📝 packages/trpc/server/document-router/schema.ts (+5 -0)

📄 Description

Description

Previously, it wasn't possible to download an audit log of a document uploaded by another user because the function used the ID of the user making the request to retrieve the document. However, the document uploaded by another user has that user's ID, not the ID of the user making the request.

Summary by CodeRabbit

  • New Features

    • Enhanced the Download Audit Log button to support team-specific logging, improving audit tracking capabilities.
    • Introduced a new mutation for downloading certificates, expanding document management functionality.
  • Bug Fixes

    • Updated input handling for the downloadAuditLogs mutation to accurately identify users using documentUploaderId.
  • Documentation

    • Revised schema definitions to include additional parameters for audit log and certificate downloads.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1268 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 8/6/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/audit-log-download` --- ### 📝 Commits (8) - [`06e3750`](https://github.com/documenso/documenso/commit/06e3750c1cb0bd2df267a2ad856251cbdda2fd2a) fix: download audit log certificate - [`eb5f562`](https://github.com/documenso/documenso/commit/eb5f5629b9e08facffc859005bd60bb6ba71bc9e) fix: dld audit log of doc uploaded by another team user and not the personal doc upld by another usr - [`495c5d4`](https://github.com/documenso/documenso/commit/495c5d4029c4269d6873c6da8b6adf0859d29b0c) fix: make document uploader it optional - [`bac978c`](https://github.com/documenso/documenso/commit/bac978c276c7cb60327a8e80bfd90830c967b8e9) fix: make document uploader id optional - [`103a768`](https://github.com/documenso/documenso/commit/103a768b4932b1e3f54f05748473aa0bd8039faa) fix: fix typo - [`38a2b8d`](https://github.com/documenso/documenso/commit/38a2b8d646bc7116885cfab36b395c3dc6f1b5c2) fix: avoid access to unauthorized audit logs - [`e6af278`](https://github.com/documenso/documenso/commit/e6af278bcf41492d8f92cb1033ee8b61da5e44e9) fix: typo - [`5b18ca9`](https://github.com/documenso/documenso/commit/5b18ca9bc28b12840620a857a48f4b939a989244) fix: tidy implementaiton ### 📊 Changes **4 files changed** (+23 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/download-audit-log-button.tsx` (+7 -2) 📝 `packages/trpc/server/document-router/router.ts` (+10 -2) 📝 `packages/trpc/server/document-router/schema.ts` (+5 -0) </details> ### 📄 Description ## Description Previously, it wasn't possible to download an audit log of a document uploaded by another user because the function used the ID of the user making the request to retrieve the document. However, the document uploaded by another user has that user's ID, not the ID of the user making the request. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the Download Audit Log button to support team-specific logging, improving audit tracking capabilities. - Introduced a new mutation for downloading certificates, expanding document management functionality. - **Bug Fixes** - Updated input handling for the downloadAuditLogs mutation to accurately identify users using documentUploaderId. - **Documentation** - Revised schema definitions to include additional parameters for audit log and certificate downloads. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1522
No description provided.