[PR #1238] [MERGED] fix: dateformat api bug #1499

New issue

Closed

opened 2026-02-26 19:33:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1238
Author: @catalinpit
Created: 7/23/2024
Status: ✅ Merged
Merged: 7/30/2024
Merged by: @Mythie

Base: main ← Head: fix/dateformat-api-bug

📝 Commits (7)

5c6ab6d fix: dateformat api bug
8f9e0e1 fix: add examples
93b7893 fix: fix example
d2aff9a fix: add timezones
34272eb Merge branch 'main' into fix/dateformat-api-bug
7131218 fix: prevent invalid timezones
43e2550 fix: api workings and ui timezone

📊 Changes

3 files changed (+75 additions, -7 deletions)

View changed files

📝 packages/api/v1/implementation.ts (+38 -1)
📝 packages/api/v1/schema.ts (+19 -2)
📝 packages/ui/primitives/document-flow/add-settings.tsx (+18 -4)

📄 Description

The dateFormat value wasn't processed correctly for documents created via the API.

Now, it checks that the dateFormat value is valid and throws an error if it is not.

Summary by CodeRabbit

New Features
- Enhanced date format and time zone validation for API requests to improve error handling.
- Updated handling of date format and time zone settings in the UI for dynamic assignment based on predefined options.
- Integrated OpenAPI documentation features into the API schema for better clarity on expected input formats.
Bug Fixes
- Fixed an issue where invalid time zones could be accepted in settings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1238 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 7/23/2024 **Status:** ✅ Merged **Merged:** 7/30/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/dateformat-api-bug` --- ### 📝 Commits (7) - [`5c6ab6d`](https://github.com/documenso/documenso/commit/5c6ab6dd68f8e314322a0e7e41f41ab4da280587) fix: dateformat api bug - [`8f9e0e1`](https://github.com/documenso/documenso/commit/8f9e0e13b171ed7f57559e37e3dddb17e5744250) fix: add examples - [`93b7893`](https://github.com/documenso/documenso/commit/93b7893ed5bc71257fb4d2a56bd05193fc79bc93) fix: fix example - [`d2aff9a`](https://github.com/documenso/documenso/commit/d2aff9a2900b41d161e16e74c15c160249daccd5) fix: add timezones - [`34272eb`](https://github.com/documenso/documenso/commit/34272eb78e8b589e8778159b574a677a8c662699) Merge branch 'main' into fix/dateformat-api-bug - [`7131218`](https://github.com/documenso/documenso/commit/71312186add3892c898a3473c38bcd1b2fc6ebcb) fix: prevent invalid timezones - [`43e2550`](https://github.com/documenso/documenso/commit/43e2550c37ab2b60a125e3dcbd07326ee26315e6) fix: api workings and ui timezone ### 📊 Changes **3 files changed** (+75 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/v1/implementation.ts` (+38 -1) 📝 `packages/api/v1/schema.ts` (+19 -2) 📝 `packages/ui/primitives/document-flow/add-settings.tsx` (+18 -4) </details> ### 📄 Description The `dateFormat` value wasn't processed correctly for documents created via the API. Now, it checks that the `dateFormat` value is valid and throws an error if it is not.  ## Summary by CodeRabbit - **New Features** - Enhanced date format and time zone validation for API requests to improve error handling. - Updated handling of date format and time zone settings in the UI for dynamic assignment based on predefined options. - Integrated OpenAPI documentation features into the API schema for better clarity on expected input formats. - **Bug Fixes** - Fixed an issue where invalid time zones could be accepted in settings.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:31 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1499

No description provided.

Rows
Columns