starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[GH-ISSUE #568] Improve Password Validation #149

New issue

Closed

opened 2026-02-26 18:45:34 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 18:45:34 +03:00

Owner

Originally created by @mayukh551 on GitHub (Oct 15, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/568

Improvement Description

The Zod schema object checks if the password is atleast 6 characters long or not.

But for a strong password we should ask the users to create a password that is 6 characters long and has the following characters:

UpperCase
Number
Symbol

password Examples: heyThere#366, ThisIsATestPassoword#100

Rationale

The benefit of creating and using a password that has an uppercase, lowercase, number, and a symbol is that it makes it much more difficult for hackers to crack.

Hackers often use automated software to try to guess passwords, and these programs are typically very good at guessing simple passwords that only use one type of character.

Checklist

I have searched the existing issues and improvement suggestions to avoid duplication.
I have provided a clear description of the improvement being suggested.
I have explained the rationale behind this improvement.
I have included any relevant technical details or design suggestions.
I understand that this is a suggestion and that there is no guarantee of implementation.

Originally created by @mayukh551 on GitHub (Oct 15, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/568  ## Improvement Description The Zod schema object checks if the `password` is atleast 6 characters long or not. But for a strong password we should ask the users to create a password that is 6 characters long and has the following characters: - UpperCase - Number - Symbol password Examples: heyThere#366, ThisIsATestPassoword#100 ## Rationale   The benefit of creating and using a password that has an uppercase, lowercase, number, and a symbol is that it makes it much more difficult for hackers to crack. Hackers often use automated software to try to guess passwords, and these programs are typically very good at guessing simple passwords that only use one type of character. ## Checklist   - [x] I have searched the existing issues and improvement suggestions to avoid duplication. - [x] I have provided a clear description of the improvement being suggested. - [x] I have explained the rationale behind this improvement. - [x] I have included any relevant technical details or design suggestions. - [x] I understand that this is a suggestion and that there is no guarantee of implementation.

kerem closed this issue

2026-02-26 18:45:35 +03:00

kerem commented

2026-02-26 18:45:35 +03:00

Author

Owner

@adithyaakrishna commented on GitHub (Oct 15, 2023):

Hey @mayukh551, there seems to be an existing issue for the validation improvement here, https://github.com/documenso/documenso/issues/464, and I've been working on the same in this PR, https://github.com/documenso/documenso/pull/469 as well

@adithyaakrishna commented on GitHub (Oct 15, 2023): Hey @mayukh551, there seems to be an existing issue for the validation improvement here, https://github.com/documenso/documenso/issues/464, and I've been working on the same in this PR, https://github.com/documenso/documenso/pull/469 as well

kerem commented

2026-02-26 18:45:35 +03:00

Author

Owner

@mayukh551 commented on GitHub (Oct 15, 2023):

oh my bad!
Closing this issue...

@mayukh551 commented on GitHub (Oct 15, 2023): oh my bad! Closing this issue...

kerem referenced this issue

2026-02-26 18:48:46 +03:00

[PR #149] [CLOSED] Replace character breaking signing in filename before storing in a database #755

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#149

No description provided.

Rows
Columns