[PR #1209] [MERGED] feat: make oidc sign in button text configurable #1473

New issue

Closed

opened 2026-02-26 19:33:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1209
Author: @Rainson12
Created: 6/29/2024
Status: ✅ Merged
Merged: 7/31/2024
Merged by: @Mythie

Base: main ← Head: feat/make-oidc-button-label-configurable

📝 Commits (2)

b281a7e feat: make oidc sign in button text configurable
e250cb6 Merge branch 'main' into feat/make-oidc-button-label-configurable

📊 Changes

6 files changed (+14 additions, -2 deletions)

View changed files

📝 .env.example (+1 -0)
📝 apps/web/src/app/(unauthenticated)/signin/page.tsx (+6 -1)
📝 apps/web/src/components/forms/signin.tsx (+3 -1)
📝 packages/lib/constants/auth.ts (+2 -0)
📝 packages/tsconfig/process-env.d.ts (+1 -0)
📝 turbo.json (+1 -0)

📄 Description

Description

The current sign in button when signing in via OIDC configured provider is always labeled with "OIDC" this might be confusing for corporate users as this is a rather technical term. Instead this PR will add another environment variable called NEXT_PRIVATE_OIDC_PROVIDER_LABEL which will adjust the label for the button so that things like Azure AD, Keycloak or Microsoft can be used.

Changes Made

Added NEXT_PRIVATE_OIDC_PROVIDER_LABEL environment variable
adjusted signin.tsx so that instead of static OIDC the environment variable will be utilized

Testing Performed

Tested locally by setting the OIDC environment variables.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Introduced support for customizable OIDC provider labels in the SignIn form.
- Users will now see a dynamic OIDC provider label during the sign-in process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1209 **Author:** [@Rainson12](https://github.com/Rainson12) **Created:** 6/29/2024 **Status:** ✅ Merged **Merged:** 7/31/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/make-oidc-button-label-configurable` --- ### 📝 Commits (2) - [`b281a7e`](https://github.com/documenso/documenso/commit/b281a7e14c47fce0481a722c7e56a61b20aa2405) feat: make oidc sign in button text configurable - [`e250cb6`](https://github.com/documenso/documenso/commit/e250cb6d5fd6bcc396820523bb0b8363cd616d03) Merge branch 'main' into feat/make-oidc-button-label-configurable ### 📊 Changes **6 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -0) 📝 `apps/web/src/app/(unauthenticated)/signin/page.tsx` (+6 -1) 📝 `apps/web/src/components/forms/signin.tsx` (+3 -1) 📝 `packages/lib/constants/auth.ts` (+2 -0) 📝 `packages/tsconfig/process-env.d.ts` (+1 -0) 📝 `turbo.json` (+1 -0) </details> ### 📄 Description ## Description The current sign in button when signing in via OIDC configured provider is always labeled with "OIDC" this might be confusing for corporate users as this is a rather technical term. Instead this PR will add another environment variable called `NEXT_PRIVATE_OIDC_PROVIDER_LABEL` which will adjust the label for the button so that things like `Azure AD`, `Keycloak` or `Microsoft` can be used. ## Changes Made - Added `NEXT_PRIVATE_OIDC_PROVIDER_LABEL` environment variable - adjusted signin.tsx so that instead of static `OIDC` the environment variable will be utilized ## Testing Performed - Tested locally by setting the OIDC environment variables. ## Checklist - [X] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [X] I have followed the project's coding style guidelines. - [X] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Introduced support for customizable OIDC provider labels in the SignIn form. - Users will now see a dynamic OIDC provider label during the sign-in process.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1473

No description provided.

Rows
Columns