[PR #1191] [MERGED] fix: show correct authentication action for account required #1459

New issue

Closed

opened 2026-02-26 19:33:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1191
Author: @Mythie
Created: 6/20/2024
Status: ✅ Merged
Merged: 6/26/2024
Merged by: @Mythie

Base: main ← Head: fix/show-sign-in-or-sign-up-for-account-required

📝 Commits (3)

cc66723 fix: show correct authentication action for account required
e527058 Merge branch 'main' into fix/show-sign-in-or-sign-up-for-account-required
1f59266 Merge branch 'main' into fix/show-sign-in-or-sign-up-for-account-required

📊 Changes

2 files changed (+14 additions, -4 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+8 -1)
📝 apps/web/src/app/(signing)/sign/[token]/signing-auth-page.tsx (+6 -3)

📄 Description

Description

When using account required auth for a given document this change now shows the sign up or sign in button depending on if an account actually exists within
Documenso.

This change should reduce friction and confusion when a recipient has been invited to a document.

Changes Made

Updated the ssr for the signing page to fetch whether a user account exists when document auth is required
Pass the user exists flag to the document auth required page

Testing Performed

Summary by CodeRabbit

New Features
- The signing page now dynamically displays "Login" or "Sign up" based on whether the recipient's email has an account. This improves the user experience by providing relevant actions based on their account status.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1191 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 6/26/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/show-sign-in-or-sign-up-for-account-required` --- ### 📝 Commits (3) - [`cc66723`](https://github.com/documenso/documenso/commit/cc667233c62420c280396e2eb84c83ace388a43b) fix: show correct authentication action for account required - [`e527058`](https://github.com/documenso/documenso/commit/e5270583224ff6f2014c67d087a376c086e47ad2) Merge branch 'main' into fix/show-sign-in-or-sign-up-for-account-required - [`1f59266`](https://github.com/documenso/documenso/commit/1f59266e089da1eadc85058f2fd98fd4c42fb5dc) Merge branch 'main' into fix/show-sign-in-or-sign-up-for-account-required ### 📊 Changes **2 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+8 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-auth-page.tsx` (+6 -3) </details> ### 📄 Description ## Description When using account required auth for a given document this change now shows the sign up or sign in button depending on if an account actually exists within Documenso. This change should reduce friction and confusion when a recipient has been invited to a document. ## Related Issue   ## Changes Made - Updated the ssr for the signing page to fetch whether a user account exists when document auth is required - Pass the user exists flag to the document auth required page ## Testing Performed - TBD  ## Summary by CodeRabbit - **New Features** - The signing page now dynamically displays "Login" or "Sign up" based on whether the recipient's email has an account. This improves the user experience by providing relevant actions based on their account status.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1459

No description provided.

Rows
Columns