starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-24 21:36:01 +03:00

[GH-ISSUE #546] Add a lint staged task for package.json changes #143

New issue

Closed

opened 2026-02-26 18:45:33 +03:00 by kerem · 4 comments

kerem commented

2026-02-26 18:45:33 +03:00

Owner

Originally created by @Mythie on GitHub (Oct 9, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/546

Originally assigned to: @adityadeshlahre on GitHub.

Improvement Description

Add a lint-staged task that identifies if any package.json files have been modified and then runs npm install to ensure we always have the latest package.json file.

Rationale

Whenever I encounter an issue I like to try and solve it for good so we don't have to worry about it again. As per #523 we accidentally forgot to commit the package-lock file and thus caused CI failures, could have happened to anyone so we should try and alleviate the burden of remembering such a mundane thing.

Proposed Solution

Create the lint staged task as per above

Alternatives (optional)

N/A

Additional Context

N/A

Checklist

I have searched the existing issues and improvement suggestions to avoid duplication.
I have provided a clear description of the improvement being suggested.
I have explained the rationale behind this improvement.
I have included any relevant technical details or design suggestions.
I understand that this is a suggestion and that there is no guarantee of implementation.

Originally created by @Mythie on GitHub (Oct 9, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/546 Originally assigned to: @adityadeshlahre on GitHub. ## Improvement Description Add a lint-staged task that identifies if any `package.json` files have been modified and then runs `npm install` to ensure we always have the latest package.json file. ## Rationale Whenever I encounter an issue I like to try and solve it for good so we don't have to worry about it again. As per #523 we accidentally forgot to commit the package-lock file and thus caused CI failures, could have happened to anyone so we should try and alleviate the burden of remembering such a mundane thing. ## Proposed Solution Create the lint staged task as per above ## Alternatives (optional) N/A ## Additional Context N/A ## Checklist - [x] I have searched the existing issues and improvement suggestions to avoid duplication. - [x] I have provided a clear description of the improvement being suggested. - [x] I have explained the rationale behind this improvement. - [x] I have included any relevant technical details or design suggestions. - [x] I understand that this is a suggestion and that there is no guarantee of implementation.

kerem

2026-02-26 18:45:33 +03:00

closed this issue
added the
good first issue

Stale

community

hacktoberfest
labels

kerem commented

2026-02-26 18:45:34 +03:00

Author

Owner

@adityadeshlahre commented on GitHub (Oct 9, 2023):

i would love to work on this issue! 😄
if its going to get public tag !

@adityadeshlahre commented on GitHub (Oct 9, 2023): i would love to work on this issue! :smile: if its going to get public tag !

kerem commented

2026-02-26 18:45:34 +03:00

Author

Owner

@Mythie commented on GitHub (Oct 9, 2023):

Sounds great!

@Mythie commented on GitHub (Oct 9, 2023): Sounds great!

kerem commented

2026-02-26 18:45:34 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 8, 2023):

This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected

@github-actions[bot] commented on GitHub (Dec 8, 2023): This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected

kerem commented

2026-02-26 18:45:34 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 16, 2023):

This issue has been closed because of inactivity.

@github-actions[bot] commented on GitHub (Dec 16, 2023): This issue has been closed because of inactivity.

kerem referenced this issue

2026-02-26 18:48:45 +03:00

[PR #143] [MERGED] Fix: typos on Readme #750

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#143

No description provided.

Rows
Columns