starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1139] [MERGED] feat: force signature fields for document signers #1420

New issue

Closed

opened 2026-02-26 19:33:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1139
Author: @catalinpit
Created: 5/2/2024
Status: ✅ Merged
Merged: 6/24/2024
Merged by: @dguyen

Base: main ← Head: feat/enforce-signature-field-warning

📝 Commits (10+)

559b721 feat: enforce signature field warning empty signature field
d5b313e chore: submit form when user clicks proceed
4c59eab chore: improve var naming and dialog content
f18b4d6 chore: update logic
8861559 chore: remove unnecessary check
99a04e5 chore: remove unnecessary code
6dba7a6 chore: remove unnecessary code
d631466 chore: implemented feedback
db05ec0 chore: server-side check
04d70c9 chore: move server-side check to sendDocument

📊 Changes

13 files changed (+148 additions, -67 deletions)

View changed files

📝 apps/marketing/content/blog/announcing-direct-links.mdx (+4 -3)
📝 apps/marketing/content/blog/how-documenso-enhances-contract-management-for-freelancers-helping-them-close-more-clients-efficiently.mdx (+7 -3)
📝 apps/marketing/content/blog/how-documenso-help-freelancers-close-more-clients-efficiently.mdx (+7 -2)
📝 apps/marketing/content/blog/sunsetting-early-adopters.mdx (+6 -3)
📝 apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx (+1 -1)
📝 packages/app-tests/e2e/document-flow/stepper-component.spec.ts (+11 -40)
📝 packages/ee/server-only/stripe/get-document-related-prices.ts.ts (+5 -1)
📝 packages/ee/server-only/stripe/get-prices-by-interval.ts (+1 -1)
📝 packages/ee/server-only/stripe/get-primary-account-plan-prices.ts (+5 -1)
📝 packages/lib/server-only/document/send-document.tsx (+27 -11)
📝 packages/prisma/seed/documents.ts (+3 -0)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+25 -1)
➕ packages/ui/primitives/document-flow/missing-signature-field-dialog.tsx (+46 -0)

📄 Description

Description

Show a dialog when the document has signers with no signature fields placed.

Changes Made

Created a new dialog that'll be triggered when the document owner tries to send a document to the signers without placing signature fields. The document owners can't proceed to the next step unless they add signature fields.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

https://github.com/documenso/documenso/assets/25515812/f1b5c34e-2ce0-40e3-804c-f05d23045710

Summary by CodeRabbit

New Features
- Introduced "Direct Links" for async signing, allowing users to create documents from templates using public links.
- Added MissingSignatureFieldDialog component to ensure users don't miss adding signature fields.
Enhancements
- Updated blog content to provide guidance on contract management and announce new pricing plans.
Bug Fixes
- Improved async signing process for better efficiency and control.
Refactor
- Improved internal code structure and import order for stripe-related functionality.
Tests
- Enhanced e2e tests to verify signature presence before document creation and updated test flows for document approval.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1139 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 5/2/2024 **Status:** ✅ Merged **Merged:** 6/24/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/enforce-signature-field-warning` --- ### 📝 Commits (10+) - [`559b721`](https://github.com/documenso/documenso/commit/559b72113d98497725592e59ea8b4978ccb1175b) feat: enforce signature field warning empty signature field - [`d5b313e`](https://github.com/documenso/documenso/commit/d5b313ed259d65f4c41fff585df6147f30449b11) chore: submit form when user clicks proceed - [`4c59eab`](https://github.com/documenso/documenso/commit/4c59eabe84c46fa3302ac821557968a2bfd89304) chore: improve var naming and dialog content - [`f18b4d6`](https://github.com/documenso/documenso/commit/f18b4d6a2a419b944f951177ad0be2e14105e64e) chore: update logic - [`8861559`](https://github.com/documenso/documenso/commit/8861559a47d9585cf71c6e3c896ca36b62ec1dbc) chore: remove unnecessary check - [`99a04e5`](https://github.com/documenso/documenso/commit/99a04e5a73856bda4402322f1b7e0bd5cefe3803) chore: remove unnecessary code - [`6dba7a6`](https://github.com/documenso/documenso/commit/6dba7a666c9710ff78e772f656f2fac2aea80ce6) chore: remove unnecessary code - [`d631466`](https://github.com/documenso/documenso/commit/d631466dca4184c9857f49f2e5cb4eae452ca6a3) chore: implemented feedback - [`db05ec0`](https://github.com/documenso/documenso/commit/db05ec0a057fb213c019624489720b6949f3213e) chore: server-side check - [`04d70c9`](https://github.com/documenso/documenso/commit/04d70c9e4e61ead6fdfa7232fdf1bb02fae76d5c) chore: move server-side check to sendDocument ### 📊 Changes **13 files changed** (+148 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/content/blog/announcing-direct-links.mdx` (+4 -3) 📝 `apps/marketing/content/blog/how-documenso-enhances-contract-management-for-freelancers-helping-them-close-more-clients-efficiently.mdx` (+7 -3) 📝 `apps/marketing/content/blog/how-documenso-help-freelancers-close-more-clients-efficiently.mdx` (+7 -2) 📝 `apps/marketing/content/blog/sunsetting-early-adopters.mdx` (+6 -3) 📝 `apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx` (+1 -1) 📝 `packages/app-tests/e2e/document-flow/stepper-component.spec.ts` (+11 -40) 📝 `packages/ee/server-only/stripe/get-document-related-prices.ts.ts` (+5 -1) 📝 `packages/ee/server-only/stripe/get-prices-by-interval.ts` (+1 -1) 📝 `packages/ee/server-only/stripe/get-primary-account-plan-prices.ts` (+5 -1) 📝 `packages/lib/server-only/document/send-document.tsx` (+27 -11) 📝 `packages/prisma/seed/documents.ts` (+3 -0) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+25 -1) ➕ `packages/ui/primitives/document-flow/missing-signature-field-dialog.tsx` (+46 -0) </details> ### 📄 Description ## Description Show a dialog when the document has signers with no signature fields placed. ## Changes Made Created a new dialog that'll be triggered when the document owner tries to send a document to the signers without placing signature fields. The document owners can't proceed to the next step unless they add signature fields. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. https://github.com/documenso/documenso/assets/25515812/f1b5c34e-2ce0-40e3-804c-f05d23045710  ## Summary by CodeRabbit - **New Features** - Introduced "Direct Links" for async signing, allowing users to create documents from templates using public links. - Added `MissingSignatureFieldDialog` component to ensure users don't miss adding signature fields. - **Enhancements** - Updated blog content to provide guidance on contract management and announce new pricing plans. - **Bug Fixes** - Improved async signing process for better efficiency and control. - **Refactor** - Improved internal code structure and import order for stripe-related functionality. - **Tests** - Enhanced e2e tests to verify signature presence before document creation and updated test flows for document approval.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:10 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:34:01 +03:00

[PR #1420] [MERGED] chore: project babel #1619

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1420

No description provided.

Rows
Columns