[GH-ISSUE #551] [Bug] Accepting signatures with white space only #142

Closed
opened 2026-02-26 18:45:33 +03:00 by kerem · 2 comments
Owner

Originally created by @Abhinav-Developer-23 on GitHub (Oct 11, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/551

Originally assigned to: @Abhinav-Developer-23 on GitHub.

Accepting signatures with white space only

Issue Description

https://documenso.com/ On this page while filling in the signature we can fill it with space only so it looks blank. it is not correct.

Steps to Reproduce

  1. go to https://documenso.com/
  2. In the third step where we fill our signatures fill it with space only

Expected Behaviour

We should fill at least one non-whitespace character. Spaces at starting and ending should be trimmed or should not be allowed

Current Behavior

We can proceed to the next step without filling in a valid signature.

Screenshots (optional)

https://github.com/documenso/documenso/assets/145282438/45cda900-65be-49ea-b2aa-8bb914498872

Environment

  • OS: ubuntu 22
  • Browser: Chrome Version 117.0.5938.132 (Official Build) (64-bit)

Checklist

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
Originally created by @Abhinav-Developer-23 on GitHub (Oct 11, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/551 Originally assigned to: @Abhinav-Developer-23 on GitHub. Accepting signatures with white space only ## Issue Description https://documenso.com/ On this page while filling in the signature we can fill it with space only so it looks blank. it is not correct. ## Steps to Reproduce 1. go to https://documenso.com/ 2. In the third step where we fill our signatures fill it with space only ## Expected Behaviour We should fill at least one non-whitespace character. Spaces at starting and ending should be trimmed or should not be allowed ## Current Behavior We can proceed to the next step without filling in a valid signature. ## Screenshots (optional) https://github.com/documenso/documenso/assets/145282438/45cda900-65be-49ea-b2aa-8bb914498872 ## Environment <!--- Please provide information about your environment, such as operating system, browser, version, etc. --> - OS: ubuntu 22 - Browser: Chrome Version 117.0.5938.132 (Official Build) (64-bit) ## Checklist - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [x] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution.
kerem 2026-02-26 18:45:33 +03:00
Author
Owner

@Abhinav-Developer-23 commented on GitHub (Oct 11, 2023):

I would like to work on this, if this is approved

<!-- gh-comment-id:1757527973 --> @Abhinav-Developer-23 commented on GitHub (Oct 11, 2023): I would like to work on this, if this is approved
Author
Owner

@Abhinav-Developer-23 commented on GitHub (Oct 13, 2023):

Same issue is there in https://documenso.com/pricing too. when we click on signup.
I will fix in the same PR

<!-- gh-comment-id:1761748630 --> @Abhinav-Developer-23 commented on GitHub (Oct 13, 2023): Same issue is there in https://documenso.com/pricing too. when we click on signup. I will fix in the same PR
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#142
No description provided.