[PR #1133] [MERGED] fix: improve sealing process #1416

New issue

Closed

opened 2026-02-26 19:33:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1133
Author: @Mythie
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/1/2024
Merged by: @Mythie

Base: main ← Head: fix/sealing-improvements

📝 Commits (2)

d3528f7 fix: improve sealing process
78dc57a fix: improvements from review

📊 Changes

3 files changed (+27 additions, -17 deletions)

View changed files

📝 packages/lib/server-only/document/complete-document-with-token.ts (+2 -6)
📝 packages/lib/server-only/document/seal-document.ts (+24 -11)
📝 packages/lib/server-only/htmltopdf/get-certificate-pdf.ts (+1 -0)

📄 Description

Description

Improves the sealing process by being strict on how long certificate generation can take, opting to fail generation and continue sealing.

Also changes the ordering of sealing so an error in the process won't also cause a document to be "COMPLETED" since it hasn't been cryptographically sealed yet.

The downside to this change is that documents that fail during sealing will require manual intervention as a signer or owner won't be able to complete the document.

Testing Performed

Modified code to force specific failure modes to occur and verified that documents were either gracefully sealed without a certificate or not sealed and not completed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1133 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/1/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/sealing-improvements` --- ### 📝 Commits (2) - [`d3528f7`](https://github.com/documenso/documenso/commit/d3528f74f058c49d9705aca6556f9d0d56c6607f) fix: improve sealing process - [`78dc57a`](https://github.com/documenso/documenso/commit/78dc57a6eb6ded773c0b7e94d3eab2fbdc8b6121) fix: improvements from review ### 📊 Changes **3 files changed** (+27 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/document/complete-document-with-token.ts` (+2 -6) 📝 `packages/lib/server-only/document/seal-document.ts` (+24 -11) 📝 `packages/lib/server-only/htmltopdf/get-certificate-pdf.ts` (+1 -0) </details> ### 📄 Description ## Description Improves the sealing process by being strict on how long certificate generation can take, opting to fail generation and continue sealing. Also changes the ordering of sealing so an error in the process won't also cause a document to be "COMPLETED" since it hasn't been cryptographically sealed yet. The downside to this change is that documents that fail during sealing will require manual intervention as a signer or owner won't be able to *complete* the document. ## Testing Performed - Modified code to force specific failure modes to occur and verified that documents were either gracefully sealed without a certificate or not sealed and not completed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:09 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:34:01 +03:00

[PR #1416] [MERGED] feat: add team user management endpoints to api #1617

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1416

No description provided.

Rows
Columns