[PR #1123] [MERGED] feat: show time in documents table #1406

Closed
opened 2026-02-26 19:33:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1123
Author: @rushatgabhane
Created: 4/28/2024
Status: Merged
Merged: 5/21/2024
Merged by: @ElTimuro

Base: mainHead: show-time


📝 Commits (8)

  • 80c03fc feat: show time in documents table
  • dca4b8e Merge branch 'main' into show-time
  • 84bbcea Merge branch 'main' into show-time
  • 968b116 Merge branch 'main' into show-time
  • bbcbc56 feat: 12h format
  • 788933b Merge branch 'main' into show-time
  • a877c64 Merge branch 'main' into show-time
  • e072e27 Merge branch 'main' into show-time

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/data-table.tsx (+7 -1)

📄 Description


name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Display time in 12h format in the documents table.

Fixes #1077

Changes Made

  • Use DateTime.DATETIME_SHORT
  • ...

Testing Performed

  • Tested time in different timezone.
  • Ran tests in web and mobile browser
  1. Login
  2. Add a document
  3. Verify that you see date and time in 12h format as per your locale.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Screenshot 2024-04-29 at 04 21 53 Screenshot 2024-04-29 at 04 22 18

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1123 **Author:** [@rushatgabhane](https://github.com/rushatgabhane) **Created:** 4/28/2024 **Status:** ✅ Merged **Merged:** 5/21/2024 **Merged by:** [@ElTimuro](https://github.com/ElTimuro) **Base:** `main` ← **Head:** `show-time` --- ### 📝 Commits (8) - [`80c03fc`](https://github.com/documenso/documenso/commit/80c03fcf3f096c645ebd7b5d85191a9816e54068) feat: show time in documents table - [`dca4b8e`](https://github.com/documenso/documenso/commit/dca4b8eaec88823e0eeef6ea01bbf8fb2df0a553) Merge branch 'main' into show-time - [`84bbcea`](https://github.com/documenso/documenso/commit/84bbcea7bbfd96bd484ee84a53385520bcbb154f) Merge branch 'main' into show-time - [`968b116`](https://github.com/documenso/documenso/commit/968b1160121a5bb2c580aed30dd91e2a7a1532e3) Merge branch 'main' into show-time - [`bbcbc56`](https://github.com/documenso/documenso/commit/bbcbc56e70f4683ffb1f784fa683eee780c428a9) feat: 12h format - [`788933b`](https://github.com/documenso/documenso/commit/788933b75d96b6171c2c41113d94f3084658955b) Merge branch 'main' into show-time - [`a877c64`](https://github.com/documenso/documenso/commit/a877c64aca42d6a19ad5f336e09ccd32d07c88a7) Merge branch 'main' into show-time - [`e072e27`](https://github.com/documenso/documenso/commit/e072e270f8773e1840c9aa49b6b907bb25972545) Merge branch 'main' into show-time ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/data-table.tsx` (+7 -1) </details> ### 📄 Description --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description Display time in 12h format in the documents table. <!--- Describe the changes introduced by this pull request. --> <!--- Explain what problem it solves or what feature/fix it adds. --> ## Related Issue <!--- If this pull request is related to a specific issue, reference it here using #issue_number. --> <!--- For example, "Fixes #123" or "Addresses #456". --> Fixes #1077 ## Changes Made <!--- Provide a summary of the changes made in this pull request. --> <!--- Include any relevant technical details or architecture changes. --> - Use DateTime.DATETIME_SHORT - ... ## Testing Performed <!--- Describe the testing that you have performed to validate these changes. --> <!--- Include information about test cases, testing environments, and results. --> - Tested time in different timezone. - Ran tests in web and mobile browser 1. Login 2. Add a document 3. Verify that you see date and time in 12h format as per your locale. ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <img width="1512" alt="Screenshot 2024-04-29 at 04 21 53" src="https://github.com/documenso/documenso/assets/29673073/778155d4-a920-40bd-acdc-7451c9c5d4b7"> <img width="300" alt="Screenshot 2024-04-29 at 04 22 18" src="https://github.com/documenso/documenso/assets/29673073/3471de0f-f426-4ea1-be1e-220462aff9e4"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1406
No description provided.