[PR #1118] [MERGED] fix: delete pending documents #1403

New issue

Closed

opened 2026-02-26 19:33:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1118
Author: @dguyen
Created: 4/26/2024
Status: ✅ Merged
Merged: 4/30/2024
Merged by: @dguyen

Base: main ← Head: fix/delete-documents

📝 Commits (5)

e663636 fix: delete pending documents
7870129 Merge branch 'main' into fix/delete-documents
bdf781b Merge branch 'main' into fix/delete-documents
1c45150 Merge branch 'main' into fix/delete-documents
f5178bc fix: refactor

📊 Changes

1 file changed (+12 additions, -10 deletions)

View changed files

📝 packages/lib/server-only/document/delete-document.ts (+12 -10)

📄 Description

Description

Currently deleting a pending document where you are a recipient off will delete the document, but will also throw an error.

This is due to the recipient being updated after the document deleted, which is only supposed to happen for completed documents.

Preference is to not merge until playwright is resolved since there's a lot of document deleting E2E tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1118 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 4/26/2024 **Status:** ✅ Merged **Merged:** 4/30/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/delete-documents` --- ### 📝 Commits (5) - [`e663636`](https://github.com/documenso/documenso/commit/e663636305718d5bf1d5fbc0fdb7b0e295ebb3d1) fix: delete pending documents - [`7870129`](https://github.com/documenso/documenso/commit/78701291865419547d0bbc9fd6437b8d045f8ca1) Merge branch 'main' into fix/delete-documents - [`bdf781b`](https://github.com/documenso/documenso/commit/bdf781bccedf649426eaaffed4fb5fd4cdbc6760) Merge branch 'main' into fix/delete-documents - [`1c45150`](https://github.com/documenso/documenso/commit/1c4515015305ce16b3a49be907017b3574c381c3) Merge branch 'main' into fix/delete-documents - [`f5178bc`](https://github.com/documenso/documenso/commit/f5178bcec00f1e5eb09aae849b8d2a1eb1c5ba01) fix: refactor ### 📊 Changes **1 file changed** (+12 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/document/delete-document.ts` (+12 -10) </details> ### 📄 Description ## Description Currently deleting a pending document where you are a recipient off will delete the document, but will also throw an error. This is due to the recipient being updated after the document deleted, which is only supposed to happen for completed documents. _Preference is to not merge until playwright is resolved since there's a lot of document deleting E2E tests._ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:06 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:59 +03:00

[PR #1403] [MERGED] style: Update web.po #1609

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1403

No description provided.

Rows
Columns