[PR #1116] [MERGED] fix: hide team webhooks from users #1400

Closed
opened 2026-02-26 19:33:05 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1116
Author: @dguyen
Created: 4/25/2024
Status: Merged
Merged: 4/26/2024
Merged by: @Mythie

Base: mainHead: fix/webhook-context


📝 Commits (1)

  • e157346 fix: hide team webhooks from users

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/lib/server-only/webhooks/get-webhooks-by-user-id.ts (+1 -0)

📄 Description

Description

Currently if you create a team webhook, you can see it in your personal webhooks.

However, interacting with them will throw errors because there is server side logic preventing any interaction with them since they are outside of the correct context.

So the solution is to either:

  • Allow the user to edit the team webhooks that they created on their personal webhooks page
  • Hide team webhooks for personal webhooks pages

This PR goes with the second option, but is open to suggestions.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1116 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 4/25/2024 **Status:** ✅ Merged **Merged:** 4/26/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/webhook-context` --- ### 📝 Commits (1) - [`e157346`](https://github.com/documenso/documenso/commit/e1573465f6e66b67b47bb83bcb4e5fa0899a3711) fix: hide team webhooks from users ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/webhooks/get-webhooks-by-user-id.ts` (+1 -0) </details> ### 📄 Description ## Description Currently if you create a team webhook, you can see it in your personal webhooks. However, interacting with them will throw errors because there is server side logic preventing any interaction with them since they are outside of the correct context. So the solution is to either: - Allow the user to edit the team webhooks that they created on their personal webhooks page - Hide team webhooks for personal webhooks pages This PR goes with the second option, but is open to suggestions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:05 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1400
No description provided.