starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1113] [MERGED] fix: complete document when all recipients are CC #1396

New issue

Closed

opened 2026-02-26 19:33:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1113
Author: @catalinpit
Created: 4/23/2024
Status: ✅ Merged
Merged: 4/27/2024
Merged by: @Mythie

Base: main ← Head: fix/doc-status-cc-role

📝 Commits (8)

0eee570 fix: complete document when all recipients are CC
4d5365b fix: complete document when all recipients are CC
3fb6942 Merge branch 'main' into fix/doc-status-cc-role
bb43547 fix: complete document when all recipients are CC
d795995 fix: edit-document line
1e33bc2 Merge branch 'main' into fix/doc-status-cc-role
4080806 fix: minor updates
b0ce06f Merge branch 'main' into fix/doc-status-cc-role

📊 Changes

1 file changed (+27 additions, -0 deletions)

View changed files

📝 packages/lib/server-only/document/send-document.tsx (+27 -0)

📄 Description

Description

Automatically marks the document as completed if all the recipients are CC.

Changes Made

Added an if statement in the last form step (onAddSubjectFormSubmit) that checks if all the recipients are CC. If so, the document status is updated to COMPLETED.

Testing Performed

Tested the changes and they work as expected.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Enhanced document sending logic to update document status based on recipient roles.
Bug Fixes
- Removed redundant form submission handling in the document editing feature.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1113 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 4/23/2024 **Status:** ✅ Merged **Merged:** 4/27/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/doc-status-cc-role` --- ### 📝 Commits (8) - [`0eee570`](https://github.com/documenso/documenso/commit/0eee57078101fc31cfb656f768187aa25413514e) fix: complete document when all recipients are CC - [`4d5365b`](https://github.com/documenso/documenso/commit/4d5365bddcd94dacad4fd6c4df3e84652b6f9504) fix: complete document when all recipients are CC - [`3fb6942`](https://github.com/documenso/documenso/commit/3fb69422e8e6d505824d6d45606934cde496ca7d) Merge branch 'main' into fix/doc-status-cc-role - [`bb43547`](https://github.com/documenso/documenso/commit/bb43547a459dc3ef3ae0d02ccf2607b674373f67) fix: complete document when all recipients are CC - [`d795995`](https://github.com/documenso/documenso/commit/d7959950e21684286caad13cbddacaa46b4d559e) fix: edit-document line - [`1e33bc2`](https://github.com/documenso/documenso/commit/1e33bc2aa3ef13b0faf029656caafd8be38f12d5) Merge branch 'main' into fix/doc-status-cc-role - [`4080806`](https://github.com/documenso/documenso/commit/40808066069d189ad21ddaf06fdaf9fee612dd56) fix: minor updates - [`b0ce06f`](https://github.com/documenso/documenso/commit/b0ce06f6fe5a413c887e4ed8edc5dd62b248938f) Merge branch 'main' into fix/doc-status-cc-role ### 📊 Changes **1 file changed** (+27 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/document/send-document.tsx` (+27 -0) </details> ### 📄 Description ## Description Automatically marks the document as completed if all the recipients are CC. ## Changes Made Added an if statement in the last form step (`onAddSubjectFormSubmit`) that checks if all the recipients are CC. If so, the document status is updated to `COMPLETED`. ## Testing Performed Tested the changes and they work as expected. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Enhanced document sending logic to update document status based on recipient roles. - **Bug Fixes** - Removed redundant form submission handling in the document editing feature.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:04 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:59 +03:00

[PR #1396] [MERGED] chore: cal.com customer story article #1606

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1396

No description provided.

Rows
Columns