[PR #1106] [MERGED] chore: added filename extension check #1393

New issue

Closed

opened 2026-02-26 19:33:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1106
Author: @adithyaakrishna
Created: 4/16/2024
Status: ✅ Merged
Merged: 4/23/2024
Merged by: @adithyaakrishna

Base: main ← Head: chore/pdf-extension

📝 Commits (3)

1126fe4 chore: added filename extension check
96e4797 Merge branch 'main' into chore/pdf-extension
f8ddb0f chore: update filename for bulk recipients

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 packages/lib/server-only/document/send-completed-email.ts (+2 -2)

📄 Description

Description:

This PR adds a check for filename title and if the title ends with .pdf then the extension isnt added or else its added

Summary by CodeRabbit

Bug Fixes
- Enhanced email attachment handling to ensure PDF files are correctly identified with a ".pdf" extension.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1106 **Author:** [@adithyaakrishna](https://github.com/adithyaakrishna) **Created:** 4/16/2024 **Status:** ✅ Merged **Merged:** 4/23/2024 **Merged by:** [@adithyaakrishna](https://github.com/adithyaakrishna) **Base:** `main` ← **Head:** `chore/pdf-extension` --- ### 📝 Commits (3) - [`1126fe4`](https://github.com/documenso/documenso/commit/1126fe4bff9d1f48ec77b576ece303164e72ed9a) chore: added filename extension check - [`96e4797`](https://github.com/documenso/documenso/commit/96e4797cddb67644e8aa6a805601fcac0b67ff49) Merge branch 'main' into chore/pdf-extension - [`f8ddb0f`](https://github.com/documenso/documenso/commit/f8ddb0f9225e5c63a74377f71ab6e65d94ebbbe7) chore: update filename for bulk recipients ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/document/send-completed-email.ts` (+2 -2) </details> ### 📄 Description **Description:** This PR adds a check for filename title and if the title ends with `.pdf` then the extension isnt added or else its added  ## Summary by CodeRabbit - **Bug Fixes** - Enhanced email attachment handling to ensure PDF files are correctly identified with a ".pdf" extension.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:03 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1393

No description provided.

Rows
Columns