starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1108] [MERGED] feat: update emails for self-signer #1392

New issue

Closed

opened 2026-02-26 19:33:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1108
Author: @catalinpit
Created: 4/18/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @dguyen

Base: main ← Head: feat/self-signer-email

📝 Commits (5)

0f28c57 feat: update emails for self-signer
7d3a2bd chore: update resend email function
278c709 chore: add reminder in the email subject
a0cf015 chore: refactor code
7a960b4 chore: refactor code

📊 Changes

4 files changed (+51 additions, -7 deletions)

View changed files

📝 packages/email/template-components/template-document-invite.tsx (+15 -2)
📝 packages/email/templates/document-invite.tsx (+6 -1)
📝 packages/lib/server-only/document/resend-document.tsx (+15 -2)
📝 packages/lib/server-only/document/send-document.tsx (+15 -2)

📄 Description

Description

Updated the email content based on whether the document owner is a recipient or not.

If the document owner is a recipient (self-signer):

the email subject will be Please view/sign/approve your document
the email header will be Please view/sign/approve your document "<your-doc-title>"
the email content will be You have initiated the document "<your-doc-title>" that requires you to view/sign/approve it.

Otherwise:

the email subject will be Please view/sign/approve this document
the email header will be <doc-owner> has invited you to view/sign/approve "<doc-title>"
the email content will be <doc-owner> has invited you to view/sign/approve the document "<doc-title>".

Related to #1091

Testing Performed

Tested the feature with a different number of recipients (including and excluding the document owner - self-signer). Tested both the sending and resending functionality.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

UI Screenshots

Summary by CodeRabbit

New Features
- Enhanced the document invitation components to support scenarios where the recipient is also the sender, providing customized email content and subject lines.
- Introduced new properties in email templates to improve clarity and relevance based on the user's role in the document signing process.
Refactor
- Updated components to use a more flexible headerContent property for displaying invitation headers, replacing previous individual inviter details.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1108 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 4/18/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/self-signer-email` --- ### 📝 Commits (5) - [`0f28c57`](https://github.com/documenso/documenso/commit/0f28c57338874d9538daefd7241c4011236f692a) feat: update emails for self-signer - [`7d3a2bd`](https://github.com/documenso/documenso/commit/7d3a2bd9eea1eb74558d80b7b193c31788d93065) chore: update resend email function - [`278c709`](https://github.com/documenso/documenso/commit/278c709e9f1a5dc5129fea0fe27b76811d6a8289) chore: add reminder in the email subject - [`a0cf015`](https://github.com/documenso/documenso/commit/a0cf01581de958b79c383f1c2e628b1f6274de21) chore: refactor code - [`7a960b4`](https://github.com/documenso/documenso/commit/7a960b43e488a1175238905cdc40f55ebe91b54a) chore: refactor code ### 📊 Changes **4 files changed** (+51 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/email/template-components/template-document-invite.tsx` (+15 -2) 📝 `packages/email/templates/document-invite.tsx` (+6 -1) 📝 `packages/lib/server-only/document/resend-document.tsx` (+15 -2) 📝 `packages/lib/server-only/document/send-document.tsx` (+15 -2) </details> ### 📄 Description ## Description Updated the email content based on whether the document owner is a recipient or not. If the document owner is a recipient (self-signer): * the email subject will be `Please view/sign/approve your document` * the email header will be `Please view/sign/approve your document "<your-doc-title>"` * the email content will be `You have initiated the document "<your-doc-title>" that requires you to view/sign/approve it.` Otherwise: * the email subject will be `Please view/sign/approve this document` * the email header will be `<doc-owner> has invited you to view/sign/approve "<doc-title>"` * the email content will be `<doc-owner> has invited you to view/sign/approve the document "<doc-title>".` ## Related Issue Related to #1091 ## Testing Performed Tested the feature with a different number of recipients (including and excluding the document owner - self-signer). Tested both the sending and resending functionality. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## UI Screenshots ![CleanShot 2024-04-18 at 12 26 11@2x](https://github.com/documenso/documenso/assets/25515812/ca80f625-befb-4cbc-a541-f2186379d2e8) ![CleanShot 2024-04-18 at 12 27 40@2x](https://github.com/documenso/documenso/assets/25515812/8bcbb6fc-ba98-4fa1-8538-2d062febd27b) ![CleanShot 2024-04-18 at 12 27 53@2x](https://github.com/documenso/documenso/assets/25515812/25d77d98-b5ec-4270-8ffa-43774fe70526) ![CleanShot 2024-04-18 at 12 30 00@2x](https://github.com/documenso/documenso/assets/25515812/a90bb8e3-3ea8-42ff-9971-559b3e81ae6f)  ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced the document invitation components to support scenarios where the recipient is also the sender, providing customized email content and subject lines. - Introduced new properties in email templates to improve clarity and relevance based on the user's role in the document signing process. - **Refactor** - Updated components to use a more flexible `headerContent` property for displaying invitation headers, replacing previous individual inviter details.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:03 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:57 +03:00

[PR #1392] [MERGED] feat: start the work on the API reference #1603

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1392

No description provided.

Rows
Columns