starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1091] [MERGED] feat: add myself as signer #1377

New issue

Closed

opened 2026-02-26 19:32:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1091
Author: @catalinpit
Created: 4/10/2024
Status: ✅ Merged
Merged: 4/16/2024
Merged by: @dguyen

Base: main ← Head: feat/add-myself-as-signer

📝 Commits (9)

80de7d3 feat: add myself as signer
2bc0407 Merge branch 'main' into feat/add-myself-as-signer
318a77c feat: add myself as signer in templates
ef1d4ed fix: make sure the user can't add its details more than once
1a81b46 Merge branch 'main' into feat/add-myself-as-signer
6b8ff45 chore: merged main
b1474de fix: fix UI issue for enterprise
052b2e3 chore: implemented feedback
2bbee22 chore: simplify code

📊 Changes

2 files changed (+87 additions, -23 deletions)

View changed files

📝 packages/ui/primitives/document-flow/add-signers.tsx (+56 -21)
📝 packages/ui/primitives/template-flow/add-template-placeholder-recipients.tsx (+31 -2)

📄 Description

Description

This PR introduces the ability to add oneself as a signer by simply clicking a button, rather than filling the details manually.

"Add Myself" in the document creation flow

https://github.com/documenso/documenso/assets/25515812/0de762e3-563a-491f-a742-9078bf1d627d

"Add Myself" in the document template creation flow

https://github.com/documenso/documenso/assets/25515812/775bae01-3f5a-4b24-abbf-a47b14ec594a

Addresses #113

Changes Made

Added a new button that grabs the details of the logged-in user and fills the fields (email, name, and role) automatically when clicked.

Testing Performed

Tested the changes locally through the UI.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Introduced the ability for users to add themselves as signers within documents seamlessly.
Enhancements
- Improved form handling logic to accommodate new self-signer functionality.
- Enhanced user interface elements to support the addition of self as a signer, including a new "Add myself" button and disabling input fields during the process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1091 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 4/10/2024 **Status:** ✅ Merged **Merged:** 4/16/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/add-myself-as-signer` --- ### 📝 Commits (9) - [`80de7d3`](https://github.com/documenso/documenso/commit/80de7d3ea94bb415f640b475951e13f59e3bb4ba) feat: add myself as signer - [`2bc0407`](https://github.com/documenso/documenso/commit/2bc0407d06c52ada15bfeaef8b747e2d43842826) Merge branch 'main' into feat/add-myself-as-signer - [`318a77c`](https://github.com/documenso/documenso/commit/318a77c936a965edf22a142e680c644c42c8a0e7) feat: add myself as signer in templates - [`ef1d4ed`](https://github.com/documenso/documenso/commit/ef1d4ed0fac8e53c55987199426cef26da65b56e) fix: make sure the user can't add its details more than once - [`1a81b46`](https://github.com/documenso/documenso/commit/1a81b468599c64aa19d59fb302c9f46453fcd8e4) Merge branch 'main' into feat/add-myself-as-signer - [`6b8ff45`](https://github.com/documenso/documenso/commit/6b8ff4567dea954d656a474438a5a2537961d3c8) chore: merged main - [`b1474de`](https://github.com/documenso/documenso/commit/b1474de2da9c8d068825c7ce50f48bbadcc690b0) fix: fix UI issue for enterprise - [`052b2e3`](https://github.com/documenso/documenso/commit/052b2e330b8b394aa45f6ebd3542b4e04177db6b) chore: implemented feedback - [`2bbee22`](https://github.com/documenso/documenso/commit/2bbee2230372629e90c684e34857348abf89263f) chore: simplify code ### 📊 Changes **2 files changed** (+87 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+56 -21) 📝 `packages/ui/primitives/template-flow/add-template-placeholder-recipients.tsx` (+31 -2) </details> ### 📄 Description ## Description This PR introduces the ability to add oneself as a signer by simply clicking a button, rather than filling the details manually. ### "Add Myself" in the document creation flow https://github.com/documenso/documenso/assets/25515812/0de762e3-563a-491f-a742-9078bf1d627d ### "Add Myself" in the document template creation flow https://github.com/documenso/documenso/assets/25515812/775bae01-3f5a-4b24-abbf-a47b14ec594a ## Related Issue Addresses [#113](https://github.com/documenso/backlog-internal/issues/113) ## Changes Made Added a new button that grabs the details of the logged-in user and fills the fields *(email, name, and role)* automatically when clicked. ## Testing Performed Tested the changes locally through the UI. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Introduced the ability for users to add themselves as signers within documents seamlessly. - **Enhancements** - Improved form handling logic to accommodate new self-signer functionality. - Enhanced user interface elements to support the addition of self as a signer, including a new "Add myself" button and disabling input fields during the process.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1377

No description provided.

Rows
Columns