[PR #1089] [MERGED] fix: return updated doc #1376

New issue

Closed

opened 2026-02-26 19:32:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1089
Author: @catalinpit
Created: 4/8/2024
Status: ✅ Merged
Merged: 4/8/2024
Merged by: @dguyen

Base: main ← Head: fix/old-data-seal-document-webhook

📝 Commits (1)

00af552 fix: return updated doc

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 packages/lib/server-only/document/seal-document.ts (+11 -1)

📄 Description

Description

Fetch the updated version of the document after sealing it and return it. Previously, the document.documentData.data wasn't up to date. Now it is.

Fixes #1088.

Testing Performed

Added console.logs in the code to make sure it returns the proper data
Set up a webhook and tested that the webhook receives the updated data

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1089 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 4/8/2024 **Status:** ✅ Merged **Merged:** 4/8/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/old-data-seal-document-webhook` --- ### 📝 Commits (1) - [`00af552`](https://github.com/documenso/documenso/commit/00af55297b6d0d222ec4d4dc15d36171ff0c668f) fix: return updated doc ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/document/seal-document.ts` (+11 -1) </details> ### 📄 Description ## Description Fetch the updated version of the document after sealing it and return it. Previously, the `document.documentData.data` wasn't up to date. Now it is. ## Related Issue Fixes #1088. ## Testing Performed * Added console.logs in the code to make sure it returns the proper data * Set up a webhook and tested that the webhook receives the updated data ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:55 +03:00

[PR #1376] [MERGED] feat: add custom font sizes to fields #1593

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1376

No description provided.

Rows
Columns