[PR #1078] [MERGED] feat: download completed docs via api #1367

New issue

Closed

opened 2026-02-26 19:32:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1078
Author: @catalinpit
Created: 4/4/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @dguyen

Base: main ← Head: feat/api-endpoint-download-doc

📝 Commits (10+)

790cf8a feat: download completed docs via api
ac6e573 Merge branch 'main' into feat/api-endpoint-download-doc
e1748d2 Merge branch 'main' into feat/api-endpoint-download-doc
a393653 chore: add s3 transport check
874e9e9 chore: add support for downloading files besides s3
2958fd9 chore: cleanup
580cfed chore: split the function in 2 functions
06993aa fix: typo
841d348 chore: support only s3 presigned url
0ddda49 chore: merged main

📊 Changes

3 files changed (+82 additions, -1 deletions)

View changed files

📝 packages/api/v1/contract.ts (+12 -0)
📝 packages/api/v1/implementation.ts (+66 -1)
📝 packages/api/v1/schema.ts (+4 -0)

📄 Description

Description

Allow users to download a completed document via API.

Testing Performed

Tested the code locally by trying to download both draft and completed docs. Works as expected.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Implemented functionality to download signed documents directly from the app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1078 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 4/4/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/api-endpoint-download-doc` --- ### 📝 Commits (10+) - [`790cf8a`](https://github.com/documenso/documenso/commit/790cf8adae39df3eb6f31ace3ff652f4dc0bdfa0) feat: download completed docs via api - [`ac6e573`](https://github.com/documenso/documenso/commit/ac6e573ce99f7bb334f71de521b2aafd2ad79a27) Merge branch 'main' into feat/api-endpoint-download-doc - [`e1748d2`](https://github.com/documenso/documenso/commit/e1748d2e19e3ed49f3f5ea5fb5336426458b4c30) Merge branch 'main' into feat/api-endpoint-download-doc - [`a393653`](https://github.com/documenso/documenso/commit/a393653611294eaeaa55e88e9a6bed454806b712) chore: add s3 transport check - [`874e9e9`](https://github.com/documenso/documenso/commit/874e9e9ae8824d5e755efc3638649dcc7a879141) chore: add support for downloading files besides s3 - [`2958fd9`](https://github.com/documenso/documenso/commit/2958fd94816dccefd62edbedfe83cb040f5809b1) chore: cleanup - [`580cfed`](https://github.com/documenso/documenso/commit/580cfedecfe3a6ac9b239a5409775bcf708f0c0b) chore: split the function in 2 functions - [`06993aa`](https://github.com/documenso/documenso/commit/06993aad0cca7114be00b9182f85f78066f48774) fix: typo - [`841d348`](https://github.com/documenso/documenso/commit/841d3489cc144c1841dd026889f8e8a51ff1d12d) chore: support only s3 presigned url - [`0ddda49`](https://github.com/documenso/documenso/commit/0ddda4945637c6512350953b842c8f73bb2a332a) chore: merged main ### 📊 Changes **3 files changed** (+82 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/v1/contract.ts` (+12 -0) 📝 `packages/api/v1/implementation.ts` (+66 -1) 📝 `packages/api/v1/schema.ts` (+4 -0) </details> ### 📄 Description ## Description Allow users to download a completed document via API. ## Testing Performed Tested the code locally by trying to download both draft and completed docs. Works as expected. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Implemented functionality to download signed documents directly from the app.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:57 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1367

No description provided.

Rows
Columns