starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 06:15:58 +03:00

[PR #1054] [MERGED] fix: render fields on document load #1350

New issue

Closed

opened 2026-02-26 19:32:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1054
Author: @dguyen
Created: 3/23/2024
Status: ✅ Merged
Merged: 3/27/2024
Merged by: @dguyen

Base: main ← Head: fix/document-pdf-mount

📝 Commits (3)

e329631 fix: display fields on document pdf load
633e92f fix: spm
4e82356 Merge branch 'main' into fix/document-pdf-mount

📊 Changes

6 files changed (+42 additions, -23 deletions)

View changed files

📝 apps/marketing/src/app/(marketing)/singleplayer/client.tsx (+1 -0)
📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+7 -1)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+16 -13)
📝 packages/ui/primitives/document-flow/add-signers.tsx (+6 -3)
📝 packages/ui/primitives/document-flow/add-subject.tsx (+6 -3)
📝 packages/ui/primitives/document-flow/add-title.tsx (+6 -3)

📄 Description

Description

Currently if you try to load the document edit page when fields need to be rendered, you will not be able to see the fields until you proceed to the next step.

This is because the fields require the document PDF to be loaded prior to rendering them.

This PR resolves that issue by only rendering the fields after the PDF is loaded.

Changes Made

Add a state to track whether the PDF is loaded
Render the fields only after the PDF is loaded

Testing Performed

Tested document flow manually and the fields are rendered correctly on load.

Checklist

I have tested these changes locally and they work as expected.
I have updated the documentation to reflect these changes, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1054 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 3/23/2024 **Status:** ✅ Merged **Merged:** 3/27/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/document-pdf-mount` --- ### 📝 Commits (3) - [`e329631`](https://github.com/documenso/documenso/commit/e32963104b233767aea6447620b783deb1fe72e6) fix: display fields on document pdf load - [`633e92f`](https://github.com/documenso/documenso/commit/633e92f13945a847d56a53ae72b34e88d3b596d4) fix: spm - [`4e82356`](https://github.com/documenso/documenso/commit/4e823567a5d7722484eba0df6b129af60f3c86e9) Merge branch 'main' into fix/document-pdf-mount ### 📊 Changes **6 files changed** (+42 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/src/app/(marketing)/singleplayer/client.tsx` (+1 -0) 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+7 -1) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+16 -13) 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+6 -3) 📝 `packages/ui/primitives/document-flow/add-subject.tsx` (+6 -3) 📝 `packages/ui/primitives/document-flow/add-title.tsx` (+6 -3) </details> ### 📄 Description ## Description Currently if you try to load the document edit page when fields need to be rendered, you will not be able to see the fields until you proceed to the next step. This is because the fields require the document PDF to be loaded prior to rendering them. This PR resolves that issue by only rendering the fields after the PDF is loaded. ## Changes Made - Add a state to track whether the PDF is loaded - Render the fields only after the PDF is loaded ## Testing Performed Tested document flow manually and the fields are rendered correctly on load. ## Checklist - [X] I have tested these changes locally and they work as expected. - [X] I have updated the documentation to reflect these changes, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:52 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:50 +03:00

[PR #1350] [MERGED] chore: field fonts #1575

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1350

No description provided.

Rows
Columns