starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-24 21:36:01 +03:00

[GH-ISSUE #512] Able to login using Forgot password #135

New issue

Closed

opened 2026-02-26 18:45:30 +03:00 by kerem · 11 comments

kerem commented

2026-02-26 18:45:30 +03:00

Owner

Originally created by @mittalsam98 on GitHub (Oct 3, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/512

Description:

When I clicked on Forgot your password? and entered my email address, a password reset email arrived in my inbox. Ideally, it should have shown an "Email not found" error. However, I was able to set a new password and then login to the app without any issue.

Not sure whether it is the intended behaviour or a bug

Would you like to work on this?
Yes

Originally created by @mittalsam98 on GitHub (Oct 3, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/512 Description: When I clicked on `Forgot your password?` and entered my email address, a password reset email arrived in my inbox. Ideally, it should have shown an "Email not found" error. However, I was able to set a new password and then login to the app without any issue. Not sure whether it is the intended behaviour or a bug Would you like to work on this? Yes

kerem

2026-02-26 18:45:30 +03:00

closed this issue
added the
💰 Rewarded
label

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@TameemAsim commented on GitHub (Oct 3, 2023):

@mittalsam98 can you please elaborate this??
Was you registered already?

@TameemAsim commented on GitHub (Oct 3, 2023): @mittalsam98 can you please elaborate this?? Was you registered already?

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@mittalsam98 commented on GitHub (Oct 3, 2023):

@18feb06 I already mentioned the retro steps.
I was not registered but still able to login via that step I mentioned above

@mittalsam98 commented on GitHub (Oct 3, 2023): @18feb06 I already mentioned the retro steps. I was not registered but still able to login via that step I mentioned above

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@dguyen commented on GitHub (Oct 4, 2023):

@mittalsam98 just to get some clarification, are you saying that when you:

Click 'Forgot your password'
Enter an email for an account that does not exist
A password reset email is sent to you
You set a password and log in

I don't think you would receive an email if you are requesting a password reset for an account that does not exist. Could you please try again with an email you are confident does not exist in the database?

Ideally, it should have shown an "Email not found" error.

Not necessarily, we intentionally display the following message to the user regardless if the account exists or not.

A password reset email has been sent, if you have an account you should see it in your inbox shortly.

@dguyen commented on GitHub (Oct 4, 2023): @mittalsam98 just to get some clarification, are you saying that when you: 1. Click 'Forgot your password' 2. Enter an email for an account that does not exist 3. A password reset email is sent to you 4. You set a password and log in I don't think you would receive an email if you are requesting a password reset for an account that does not exist. Could you please try again with an email you are confident does not exist in the database? > Ideally, it should have shown an "Email not found" error. Not necessarily, we intentionally display the following message to the user regardless if the account exists or not. > A password reset email has been sent, if you have an account you should see it in your inbox shortly.

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@catalinpit commented on GitHub (Oct 4, 2023):

I couldn't reproduce the issue.

@catalinpit commented on GitHub (Oct 4, 2023): I couldn't reproduce the issue.

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@mittalsam98 commented on GitHub (Oct 4, 2023):

Now I am not getting the email, but I created one account like this only

@mittalsam98 commented on GitHub (Oct 4, 2023): Now I am not getting the email, but I created one account like this only

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@mittalsam98 commented on GitHub (Oct 4, 2023):

Oh got the issue, how I am able to login, these are retro steps

Open this Signup Modal and just enter the Name and Email ID and click on Claim the ... without any subscription purchase
Now go to Login and follow the above mentioned steps

I think we are storing the email of click of Claim button click

@mittalsam98 commented on GitHub (Oct 4, 2023): Oh got the issue, how I am able to login, these are retro steps 1. Open this Signup Modal and just enter the `Name` and `Email ID` and click on `Claim the ..`. without any subscription purchase ![image](https://github.com/documenso/documenso/assets/42431274/3bfbc4bd-7897-405b-b3bd-55f7ea462f07) 2. Now go to Login and follow the above mentioned steps I think we are storing the email of click of Claim button click

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@dguyen commented on GitHub (Oct 5, 2023):

Oh okay so when you go through the early adopter sequence it'll create an account and will provide you a password at the end of it when you checkout.

Currently this won't work on staging since it's not setup there, but your account will still be created.

This is currently a non-issue, but there can definitely be improvements to the flow (the early adopter sign up flow).

@dguyen commented on GitHub (Oct 5, 2023): Oh okay so when you go through the early adopter sequence it'll create an account and will provide you a password at the end of it when you checkout. Currently this won't work on staging since it's not setup there, but your account will still be created. This is currently a non-issue, but there can definitely be improvements to the flow (the early adopter sign up flow).

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@mittalsam98 commented on GitHub (Oct 5, 2023):

Yeah ideally IMO user account should be created only when every steps has been completed successfully

@mittalsam98 commented on GitHub (Oct 5, 2023): Yeah ideally IMO user account should be created only when every steps has been completed successfully

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@dguyen commented on GitHub (Oct 6, 2023):

Created a separate issue specifically for this #532

/tip 25

@dguyen commented on GitHub (Oct 6, 2023): Created a separate issue specifically for this #532 /tip 25

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@algora-pbc[bot] commented on GitHub (Oct 6, 2023):

@mittalsam98: You just got a $25 tip! 👉 Complete your Algora onboarding to collect your payment.

@algora-pbc[bot] commented on GitHub (Oct 6, 2023): @mittalsam98: You just got a **$25** tip! 👉 [Complete your Algora onboarding](https://console.algora.io) to collect your payment.

kerem commented

2026-02-26 18:45:31 +03:00

Author

Owner

@algora-pbc[bot] commented on GitHub (Oct 6, 2023):

🎉🎈 @mittalsam98 has been awarded $25! 🎈🎊

@algora-pbc[bot] commented on GitHub (Oct 6, 2023): 🎉🎈 @mittalsam98 has been awarded **$25**! 🎈🎊

kerem referenced this issue

2026-02-26 18:48:44 +03:00

[PR #135] [MERGED] fix: signing email breaks on small devices #742

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#135

No description provided.

Rows
Columns