[PR #1035] [MERGED] fix: disable edit signer inputs #1332

New issue

Closed

opened 2026-02-26 19:32:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1035
Author: @dguyen
Created: 3/18/2024
Status: ✅ Merged
Merged: 3/18/2024
Merged by: @dguyen

Base: main ← Head: fix/disable-edit-signer-inputs

📝 Commits (1)

d945e87 fix: disable edit signer inputs

📊 Changes

1 file changed (+8 additions, -3 deletions)

View changed files

📝 packages/ui/primitives/document-flow/add-signers.tsx (+8 -3)

📄 Description

Description

Update the add signer form to disable the signers when required.

I assume the actual issue is that {...field} was spreading a disabled prop which was overriding our one.

Changes Made

Use fieldset to disable inputs
Manually disable select since fieldset doesn't work for that select for some reason

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1035 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 3/18/2024 **Status:** ✅ Merged **Merged:** 3/18/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/disable-edit-signer-inputs` --- ### 📝 Commits (1) - [`d945e87`](https://github.com/documenso/documenso/commit/d945e879bc8ad6f5dab1f36df073098aeb80b7a6) fix: disable edit signer inputs ### 📊 Changes **1 file changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+8 -3) </details> ### 📄 Description ## Description Update the add signer form to disable the signers when required. I assume the actual issue is that `{...field}` was spreading a disabled prop which was overriding our one. ## Changes Made - Use fieldset to disable inputs - Manually disable select since fieldset doesn't work for that select for some reason --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:49 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:48 +03:00

[PR #1332] [MERGED] fix: prefill advanced field settings with current field meta in template #1564

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1332

No description provided.

Rows
Columns