[PR #1013] [MERGED] fix: update docker documentation and include cert env vars #1320

Closed
opened 2026-02-26 19:32:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1013
Author: @Mythie
Created: 3/10/2024
Status: Merged
Merged: 3/10/2024
Merged by: @Mythie

Base: mainHead: fix/resolve-docker-issues


📝 Commits (3)

  • 415f79f fix: update docker docs and compose files
  • 608e622 fix: update testing compose config
  • 9e1b2e5 fix: update sharp dependency

📊 Changes

7 files changed (+74 additions, -83 deletions)

View changed files

📝 .env.example (+10 -0)
📝 apps/marketing/package.json (+1 -1)
📝 apps/web/package.json (+1 -1)
📝 docker/README.md (+15 -1)
📝 docker/production/compose.yml (+3 -0)
📝 docker/testing/compose.yml (+3 -0)
📝 package-lock.json (+41 -80)

📄 Description

Description

Updates the docker documentation and compose files to include key file related configuration for self hosters. This was missed as the key file environment variables weren't documented in the .env.example file which was used for creating the docker documentation.

#1012

Changes Made

  • Updated the docker configuration to include key file environment variables
  • Updated the .env.example to include key file env vars
  • Updated the compose images to use volumes for key files

Testing Performed

  • I have used the containers with the updated values and confirmed that they work as expected

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

N/A


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1013 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 3/10/2024 **Status:** ✅ Merged **Merged:** 3/10/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/resolve-docker-issues` --- ### 📝 Commits (3) - [`415f79f`](https://github.com/documenso/documenso/commit/415f79f82184ab21e6cbcc64cdd5541e3ccc3145) fix: update docker docs and compose files - [`608e622`](https://github.com/documenso/documenso/commit/608e622f69a7520a1d70941b2f47547e3a384634) fix: update testing compose config - [`9e1b2e5`](https://github.com/documenso/documenso/commit/9e1b2e5cc3ca51e96fee68578675ee9e483a23c5) fix: update sharp dependency ### 📊 Changes **7 files changed** (+74 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+10 -0) 📝 `apps/marketing/package.json` (+1 -1) 📝 `apps/web/package.json` (+1 -1) 📝 `docker/README.md` (+15 -1) 📝 `docker/production/compose.yml` (+3 -0) 📝 `docker/testing/compose.yml` (+3 -0) 📝 `package-lock.json` (+41 -80) </details> ### 📄 Description ## Description Updates the docker documentation and compose files to include key file related configuration for self hosters. This was missed as the key file environment variables weren't documented in the `.env.example` file which was used for creating the docker documentation. ## Related Issue #1012 ## Changes Made - Updated the docker configuration to include key file environment variables - Updated the .env.example to include key file env vars - Updated the compose images to use volumes for key files ## Testing Performed - I have used the containers with the updated values and confirmed that they work as expected ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:32:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1320
No description provided.