[PR #1009] [MERGED] feat: require confirmation for user account deletion #1319

New issue

Closed

opened 2026-02-26 19:32:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1009
Author: @Gautam-Hegde
Created: 3/8/2024
Status: ✅ Merged
Merged: 3/12/2024
Merged by: @Mythie

Base: main ← Head: feat/typeInDeletion

📝 Commits (10+)

98667da chore: code tidy
6e22eff feat: command grp border
ab8c8e2 Merge branch 'main' of https://github.com/Gautam-Hegde/documenso
6fc3803 Merge branch 'main' of https://github.com/Gautam-Hegde/documenso
a4806f9 Merge branch 'main' of https://github.com/Gautam-Hegde/documenso
ad92b1a feat: typeIn confirmation
b433225 Update command.tsx
63c2330 Merge branch 'main' into feat/typeInDeletion
f2aa0cd Merge branch 'main' into feat/typeInDeletion
efb90ca chore: use email confirmation

📊 Changes

2 files changed (+28 additions, -2 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/settings/profile/delete-account-dialog.tsx (+26 -2)
📝 packages/app-tests/e2e/test-delete-user.spec.ts (+2 -0)

📄 Description

This PR adds the necessary user friction in the Delete Dialog, ensuring that users are intentionally deleting their accounts.

User must disable 2FA to delete the account.

Explicit user confirmation

fixes #998

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1009 **Author:** [@Gautam-Hegde](https://github.com/Gautam-Hegde) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/12/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/typeInDeletion` --- ### 📝 Commits (10+) - [`98667da`](https://github.com/documenso/documenso/commit/98667dac15235a937d9effbce218aa2a50466108) chore: code tidy - [`6e22eff`](https://github.com/documenso/documenso/commit/6e22eff5a14905a337fdf5b51aa2a0fe88708fb8) feat: command grp border - [`ab8c8e2`](https://github.com/documenso/documenso/commit/ab8c8e2a578dc7430818ddb9123dc0cd85fcf53f) Merge branch 'main' of https://github.com/Gautam-Hegde/documenso - [`6fc3803`](https://github.com/documenso/documenso/commit/6fc3803ad22e8494d8303af6638d7cce545fcb52) Merge branch 'main' of https://github.com/Gautam-Hegde/documenso - [`a4806f9`](https://github.com/documenso/documenso/commit/a4806f933e60cf2f8f80ee2660b77e37ea3cfabe) Merge branch 'main' of https://github.com/Gautam-Hegde/documenso - [`ad92b1a`](https://github.com/documenso/documenso/commit/ad92b1ac238a7e970a7d1adfceab84d57b25c8ba) feat: typeIn confirmation - [`b433225`](https://github.com/documenso/documenso/commit/b4332257627b442929d43bc41d1975ee1784d370) Update command.tsx - [`63c2330`](https://github.com/documenso/documenso/commit/63c23301a9a00073fe681e6030e2e6b7a140b856) Merge branch 'main' into feat/typeInDeletion - [`f2aa0cd`](https://github.com/documenso/documenso/commit/f2aa0cd714c2718df93d977d6312dee7ecd6fd47) Merge branch 'main' into feat/typeInDeletion - [`efb90ca`](https://github.com/documenso/documenso/commit/efb90ca5fb6748c6aa409516c2e6a669b495f220) chore: use email confirmation ### 📊 Changes **2 files changed** (+28 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/settings/profile/delete-account-dialog.tsx` (+26 -2) 📝 `packages/app-tests/e2e/test-delete-user.spec.ts` (+2 -0) </details> ### 📄 Description ### This PR adds the necessary user friction in the Delete Dialog, ensuring that users are intentionally deleting their accounts. - User must disable 2FA to delete the account. ![2fa](https://github.com/documenso/documenso/assets/85569489/634fd9dd-2aea-4dd8-a231-ade82b71fc7d) - Explicit user confirmation ![!2FA](https://github.com/documenso/documenso/assets/85569489/11a074b6-7ec7-4568-ba1a-ee884766047b) fixes #998 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:45 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:45 +03:00

[PR #1319] [MERGED] fix: broken endpoint to update a field in a document #1554

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1319

No description provided.

Rows
Columns