starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[GH-ISSUE #507] [Bug] - Non Responsiveness of Add your signature modal #127

New issue

Closed

opened 2026-02-26 18:45:29 +03:00 by kerem · 6 comments

kerem commented

2026-02-26 18:45:29 +03:00

Owner

Originally created by @adithyaakrishna on GitHub (Oct 3, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/507

Description:

The Add your signature modal at https://documenso.com/ on Mobile view is not centered and has the close icon very close to the search bar which may cause users to click on other buttons by mistake.

Please refer the screenshot below

The expected outcome would be to center the modal on mobile views and give sufficient margins around it

Originally created by @adithyaakrishna on GitHub (Oct 3, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/507 **Description:** The _**Add your signature modal**_ at https://documenso.com/ on Mobile view is not centered and has the close icon very close to the search bar which may cause users to click on other buttons by mistake. Please refer the screenshot below ![IMG_9070](https://github.com/documenso/documenso/assets/23498248/dea0ee7a-0f58-4970-98f5-c469e495b78a) The expected outcome would be to center the modal on mobile views and give sufficient margins around it

kerem

2026-02-26 18:45:29 +03:00

closed this issue
added the
type: bug

community
labels

kerem commented

2026-02-26 18:45:29 +03:00

Author

Owner

@mittalsam98 commented on GitHub (Oct 3, 2023):

Hey, pls assign this to me. I would love to work on this

@mittalsam98 commented on GitHub (Oct 3, 2023): Hey, pls assign this to me. I would love to work on this

kerem commented

2026-02-26 18:45:29 +03:00

Author

Owner

@adithyaakrishna commented on GitHub (Oct 3, 2023):

@mittalsam98 Sure! Please feel free to take this up and send a PR towards it :)

@adithyaakrishna commented on GitHub (Oct 3, 2023): @mittalsam98 Sure! Please feel free to take this up and send a PR towards it :)

kerem commented

2026-02-26 18:45:29 +03:00

Author

Owner

@adityadeshlahre commented on GitHub (Oct 4, 2023):

hey @adithyaakrishna and @mittalsam98
since i worked on this PR #516
it looks like this issue is device specific because there is already a perfect margin exist !
may be i am wrong 😄

Screenshot

ThankYou !

@adityadeshlahre commented on GitHub (Oct 4, 2023): hey @adithyaakrishna and @mittalsam98 since i worked on this PR #516 it looks like this issue is device specific because there is already a perfect margin exist ! may be i am wrong :smile: **Screenshot** ![margined2023-10-04_12-24](https://github.com/documenso/documenso/assets/132184385/95b477d3-afcf-4fb4-bce5-757766216bf7) ThankYou !

kerem commented

2026-02-26 18:45:29 +03:00

Author

Owner

@dguyen commented on GitHub (Oct 5, 2023):

Hey @adithyaakrishna, just wanted to check

has the close icon very close to the search bar which may cause users to click on other buttons by mistake.

Which search bar are you referring to? The mobile browser search bar?

@dguyen commented on GitHub (Oct 5, 2023): Hey @adithyaakrishna, just wanted to check > has the close icon very close to the search bar which may cause users to click on other buttons by mistake. Which search bar are you referring to? The mobile browser search bar?

kerem commented

2026-02-26 18:45:29 +03:00

Author

Owner

@adithyaakrishna commented on GitHub (Oct 5, 2023):

@dguyen Yes, was referring to the mobile browser one, if I opened it in web view of iOS, it is pretty close to the top, so how about we center the modal to the mobile screen?

@adithyaakrishna commented on GitHub (Oct 5, 2023): @dguyen Yes, was referring to the mobile browser one, if I opened it in web view of iOS, it is pretty close to the top, so how about we center the modal to the mobile screen?

kerem commented

2026-02-26 18:45:29 +03:00

Author

Owner

@dguyen commented on GitHub (Oct 6, 2023):

@adithyaakrishna after some internal discussion, the team believes that the best way forward is to have the dialog default to full screen on mobile.

Proposed changes:

Keep the current ability to position the dialog
Make dialogs by default full screen on mobile (when dialog prop position is not set)
Move the X slightly further from the corner of the screen

What do you think?

@dguyen commented on GitHub (Oct 6, 2023): @adithyaakrishna after some internal discussion, the team believes that the best way forward is to have the dialog default to full screen on mobile. Proposed changes: - Keep the current ability to position the dialog - Make dialogs by default full screen on mobile (when dialog prop position is not set) - Move the X slightly further from the corner of the screen What do you think?

kerem referenced this issue

2026-02-26 18:48:42 +03:00

[PR #127] [CLOSED] replace neon with zinc-800 #737

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#127

No description provided.

Rows
Columns