[PR #918] [MERGED] fix: recipients with CC role not being editable #1250

New issue

Closed

opened 2026-02-26 19:32:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/918
Author: @dguyen
Created: 2/7/2024
Status: ✅ Merged
Merged: 2/9/2024
Merged by: @dguyen

Base: main ← Head: fix/recipient-cc-role

📝 Commits (1)

a45b764 fix: recipient CC role not being editable

📊 Changes

6 files changed (+29 additions, -12 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+1 -1)
📝 packages/lib/server-only/field/set-fields-for-document.ts (+4 -0)
📝 packages/lib/server-only/recipient/set-recipients-for-document.ts (+8 -2)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+11 -7)
📝 packages/ui/primitives/document-flow/add-signers.tsx (+4 -1)

📄 Description

Description

Fixed issue where setting a recipient role as CC will prevent any further changes as it is considered as "sent" and "signed".

Other changes

Prevent editing document after completed
Removed CC and Viewers from the field recipient list since they will never be filled
Minor UI issues

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have followed the project's coding style guidelines.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/918 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 2/7/2024 **Status:** ✅ Merged **Merged:** 2/9/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/recipient-cc-role` --- ### 📝 Commits (1) - [`a45b764`](https://github.com/documenso/documenso/commit/a45b764fd4a6f66543801748b6b6c7b403010310) fix: recipient CC role not being editable ### 📊 Changes **6 files changed** (+29 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+1 -1) 📝 `packages/lib/server-only/field/set-fields-for-document.ts` (+4 -0) 📝 `packages/lib/server-only/recipient/set-recipients-for-document.ts` (+8 -2) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+11 -7) 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+4 -1) </details> ### 📄 Description ## Description Fixed issue where setting a recipient role as CC will prevent any further changes as it is considered as "sent" and "signed". ## Other changes - Prevent editing document after completed - Removed CC and Viewers from the field recipient list since they will never be filled - Minor UI issues ## Checklist - [X] I have tested these changes locally and they work as expected. - [X] I have added/updated tests that prove the effectiveness of these changes. - [X] I have followed the project's coding style guidelines. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:28 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:33 +03:00

[PR #1250] [MERGED] chore: add translations #1510

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1250

No description provided.

Rows
Columns