[PR #916] [MERGED] fix: update field remove logic #1248

New issue

Closed

opened 2026-02-26 19:32:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/916
Author: @dguyen
Created: 2/7/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @Mythie

Base: main ← Head: fix/remove-fields

📝 Commits (1)

58e2eda fix: update field remove logic

📊 Changes

1 file changed (+1 additions, -5 deletions)

View changed files

📝 packages/lib/server-only/field/set-fields-for-document.ts (+1 -5)

📄 Description

Description

Fixed issue where you are prevented from removing fields for a recipient that has multiple fields.

Example:

Recipient has 3 fields, you remove 1 and proceed to next step. In the next step the field reappears as it was not deleted.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have followed the project's coding style guidelines.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/916 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 2/7/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/remove-fields` --- ### 📝 Commits (1) - [`58e2eda`](https://github.com/documenso/documenso/commit/58e2eda5e9929c91fd5ab0a904cbbec2ecb8208f) fix: update field remove logic ### 📊 Changes **1 file changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/field/set-fields-for-document.ts` (+1 -5) </details> ### 📄 Description ## Description Fixed issue where you are prevented from removing fields for a recipient that has multiple fields. Example: Recipient has 3 fields, you remove 1 and proceed to next step. In the next step the field reappears as it was not deleted. ## Checklist - [X] I have tested these changes locally and they work as expected. - [X] I have added/updated tests that prove the effectiveness of these changes. - [X] I have followed the project's coding style guidelines. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:27 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:33 +03:00

[PR #1248] [MERGED] chore: add translations #1508

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1248

No description provided.

Rows
Columns