[PR #876] [CLOSED] fix: fix header layout shift #1225

Closed
opened 2026-02-26 19:32:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/876
Author: @ksushant6566
Created: 1/26/2024
Status: Closed

Base: mainHead: fix/layout-shifts


📝 Commits (2)

  • 83e2d75 fix: fix header layout shift
  • a98661d fix(header): hide desktop nav on screens smaller than 'lg', and center header for all screens

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 apps/web/src/components/(dashboard)/layout/desktop-nav.tsx (+1 -1)
📝 apps/web/src/components/(dashboard)/layout/header.tsx (+2 -2)

📄 Description

fix #875

The problem was due to the scroll bar. Solution is to use vw unit for header as they are not affected by scroll-bars.

Loom: https://www.loom.com/share/057755740fca48c18bccb08912b65f5c?sid=3b3b674c-3991-45bb-871d-f7795a145525


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/876 **Author:** [@ksushant6566](https://github.com/ksushant6566) **Created:** 1/26/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/layout-shifts` --- ### 📝 Commits (2) - [`83e2d75`](https://github.com/documenso/documenso/commit/83e2d752cb971186bdec63757244794c997a9d2a) fix: fix header layout shift - [`a98661d`](https://github.com/documenso/documenso/commit/a98661d967bb00c98a54493cf3fcacaac0a13128) fix(header): hide desktop nav on screens smaller than 'lg', and center header for all screens ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/components/(dashboard)/layout/desktop-nav.tsx` (+1 -1) 📝 `apps/web/src/components/(dashboard)/layout/header.tsx` (+2 -2) </details> ### 📄 Description fix #875 The problem was due to the scroll bar. Solution is to use ``vw`` unit for header as they are not affected by scroll-bars. Loom: https://www.loom.com/share/057755740fca48c18bccb08912b65f5c?sid=3b3b674c-3991-45bb-871d-f7795a145525 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:32:21 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1225
No description provided.