[PR #839] [MERGED] fix: fix bug for completed document shortcut #1199

Closed
opened 2026-02-26 19:32:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/839
Author: @catalinpit
Created: 1/17/2024
Status: Merged
Merged: 1/18/2024
Merged by: @catalinpit

Base: mainHead: feat/fix-completed-doc-shortcut


📝 Commits (2)

  • 3a5a78f fix: fix bug for completed document shortcut
  • 0aedf65 fix: tidy code

📊 Changes

1 file changed (+17 additions, -2 deletions)

View changed files

📝 apps/web/src/components/(dashboard)/common/command-menu.tsx (+17 -2)

📄 Description

When you're in the /documents page in the dashboard, if you hover over a draft and a completed document, you'll see different URLs.

At the moment, the shortcut tries to go to the following URL for a completed document /documents/{doc-id}.

However, that's the wrong URL, since the URL for a completed doc is /sign/{token} when the user is the recipient, not the one that sent the document for signing.

If it's the document owner & the document is completed, the URL is fine as /documents/{doc-id}.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/839 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 1/17/2024 **Status:** ✅ Merged **Merged:** 1/18/2024 **Merged by:** [@catalinpit](https://github.com/catalinpit) **Base:** `main` ← **Head:** `feat/fix-completed-doc-shortcut` --- ### 📝 Commits (2) - [`3a5a78f`](https://github.com/documenso/documenso/commit/3a5a78f21b8519d6bd99d62b52eeee24a24646b1) fix: fix bug for completed document shortcut - [`0aedf65`](https://github.com/documenso/documenso/commit/0aedf65a3546557df706fcbe1a988c07874f328b) fix: tidy code ### 📊 Changes **1 file changed** (+17 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/components/(dashboard)/common/command-menu.tsx` (+17 -2) </details> ### 📄 Description When you're in the `/documents` page in the dashboard, if you hover over a draft and a completed document, you'll see different URLs. At the moment, the shortcut tries to go to the following URL for a completed document `/documents/{doc-id}`. However, that's the wrong URL, since the URL for a completed doc is `/sign/{token}` when the user is the recipient, not the one that sent the document for signing. If it's the document owner & the document is completed, the URL is fine as `/documents/{doc-id}`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:32:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1199
No description provided.