starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 06:15:58 +03:00

[PR #809] [MERGED] fix: fixed the deleting signature block issue on touchscreens #1193

New issue

Closed

opened 2026-02-26 19:32:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/809
Author: @ashrafchowdury
Created: 1/8/2024
Status: ✅ Merged
Merged: 1/15/2024
Merged by: @Mythie

Base: main ← Head: fix/bug-798-signatures-block

📝 Commits (2)

a71078c fix: fixed the deleting signature block issue on touchscreens
d73ef57 Merge branch 'main' into fix/bug-798-signatures-block

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/ui/primitives/document-flow/field-item.tsx (+1 -0)

📄 Description

Description

Fixed the deleting signature block issue on touchscreens, for some reason the onClick event isn't working on the touchscreens that's why I've added onTouchEnd event to delete the signature block when the user clicks on it.

Changes

Added an onTouchEnd event to the delete button on the signature block.

Preview

https://github.com/documenso/documenso/assets/87828904/c952a5ff-3188-4859-852c-617547d4b369

Issue

Closes #798

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/809 **Author:** [@ashrafchowdury](https://github.com/ashrafchowdury) **Created:** 1/8/2024 **Status:** ✅ Merged **Merged:** 1/15/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/bug-798-signatures-block` --- ### 📝 Commits (2) - [`a71078c`](https://github.com/documenso/documenso/commit/a71078cbd57428aa01025b6841dfba4af39452ed) fix: fixed the deleting signature block issue on touchscreens - [`d73ef57`](https://github.com/documenso/documenso/commit/d73ef57794bfe9337adf575fa99369f7fe72f127) Merge branch 'main' into fix/bug-798-signatures-block ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/document-flow/field-item.tsx` (+1 -0) </details> ### 📄 Description ## Description Fixed the deleting signature block issue on touchscreens, for some reason the `onClick` event isn't working on the touchscreens that's why I've added `onTouchEnd` event to delete the signature block when the user clicks on it. ## Changes 1. Added an `onTouchEnd` event to the delete button on the signature block. ## Preview https://github.com/documenso/documenso/assets/87828904/c952a5ff-3188-4859-852c-617547d4b369 ## Issue Closes #798 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:14 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:21 +03:00

[PR #1193] [MERGED] feat: copy and paste fields #1460

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1193

No description provided.

Rows
Columns