starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #805] [MERGED] feat: jump to next field #1190

New issue

Closed

opened 2026-02-26 19:32:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/805
Author: @catalinpit
Created: 1/5/2024
Status: ✅ Merged
Merged: 1/10/2024
Merged by: @Mythie

Base: main ← Head: feat/fix-no-jump-to-sign-field

📝 Commits (3)

fface15 feat: jump to next field
4fd6a0d chore: update onOpenChange
3054d84 chore: implemented feedback

📊 Changes

2 files changed (+11 additions, -3 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+6 -0)
📝 apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx (+5 -3)

📄 Description

Fixes #710

When the fields are not filled, the button will have the outline variant and it'll say "Fill fields". Clicking on the button takes you to the unfilled field.

Once all fields are filled, the button will be green and it'll say "Complete".

Created the PR to move faster and ship the changes asap.

PR based on these PRs:

https://github.com/documenso/documenso/pull/739 by @Hiperultimate
https://github.com/documenso/documenso/pull/729 by @ksushant6566
https://github.com/documenso/documenso/pull/730 by @ketanMehtaa

Thank you for the work, folks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/805 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 1/5/2024 **Status:** ✅ Merged **Merged:** 1/10/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/fix-no-jump-to-sign-field` --- ### 📝 Commits (3) - [`fface15`](https://github.com/documenso/documenso/commit/fface15a22002ebb676a36cb6670ae15fd152939) feat: jump to next field - [`4fd6a0d`](https://github.com/documenso/documenso/commit/4fd6a0d5b6346ccd273d79175877434015112ef6) chore: update onOpenChange - [`3054d84`](https://github.com/documenso/documenso/commit/3054d84ba70eb737e27b85e33b82a8541a822b43) chore: implemented feedback ### 📊 Changes **2 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+6 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx` (+5 -3) </details> ### 📄 Description Fixes #710 When the fields are not filled, the button will have the `outline` variant and it'll say "Fill fields". Clicking on the button takes you to the unfilled field. ![CleanShot 2024-01-05 at 12 58 24](https://github.com/documenso/documenso/assets/25515812/ed92b15a-47f1-4700-958b-071574868445) Once all fields are filled, the button will be green and it'll say "Complete". ![CleanShot 2024-01-05 at 12 58 30](https://github.com/documenso/documenso/assets/25515812/d8b4f7a3-4b90-4766-bf67-7fd3b0d7b2e8) Created the PR to move faster and ship the changes asap. PR based on these PRs: - https://github.com/documenso/documenso/pull/739 by @Hiperultimate - https://github.com/documenso/documenso/pull/729 by @ksushant6566 - https://github.com/documenso/documenso/pull/730 by @ketanMehtaa Thank you for the work, folks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:13 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:21 +03:00

[PR #1190] [MERGED] feat: add changelog to marketing #1457

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1190

No description provided.

Rows
Columns