starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #788] [MERGED] fix: resolve conflicting z-index values #1181

New issue

Closed

opened 2026-02-26 19:32:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/788
Author: @dguyen
Created: 12/27/2023
Status: ✅ Merged
Merged: 12/28/2023
Merged by: @dguyen

Base: main ← Head: fix/z-index-ordering

📝 Commits (2)

5847378 fix: resolve conflicting z-index values
42978e7 fix: z-index for select primitive

📊 Changes

4 files changed (+4 additions, -4 deletions)

View changed files

📝 apps/web/src/components/(dashboard)/layout/header.tsx (+1 -1)
📝 packages/ui/primitives/dialog.tsx (+1 -1)
📝 packages/ui/primitives/select.tsx (+1 -1)
📝 packages/ui/primitives/toast.tsx (+1 -1)

📄 Description

Description

Currently there are various z-index values that are causing:

Toasts to be placed behind dialog blur background
Menu being cropped off by header

Changes Made

Revert z-[1000] back to z-50 for the header (not exactly sure why it was bumped)
Refactor z-indexes over 9000 to start from 1000
Ensure z-index of toast is higher than dialog

Testing Performed

Mobile toast is on top

Toast is in-front of blurred dialog background

Dropdown is no longer being cropped off

Checklist

I have tested these changes locally and they work as expected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/788 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 12/27/2023 **Status:** ✅ Merged **Merged:** 12/28/2023 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/z-index-ordering` --- ### 📝 Commits (2) - [`5847378`](https://github.com/documenso/documenso/commit/5847378cce0afcfcda50f8c75551f18993cc454d) fix: resolve conflicting z-index values - [`42978e7`](https://github.com/documenso/documenso/commit/42978e759cc41115eb3032a72795a9603a835fdd) fix: z-index for select primitive ### 📊 Changes **4 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/components/(dashboard)/layout/header.tsx` (+1 -1) 📝 `packages/ui/primitives/dialog.tsx` (+1 -1) 📝 `packages/ui/primitives/select.tsx` (+1 -1) 📝 `packages/ui/primitives/toast.tsx` (+1 -1) </details> ### 📄 Description ## Description Currently there are various z-index values that are causing: - Toasts to be placed behind dialog blur background - Menu being cropped off by header ## Changes Made - Revert `z-[1000]` back to `z-50` for the header (not exactly sure why it was bumped) - Refactor z-indexes over 9000 to start from 1000 - Ensure z-index of toast is higher than dialog ## Testing Performed **Mobile toast is on top** ![image](https://github.com/documenso/documenso/assets/20962767/386e1b66-7422-4d41-a8ec-c57ad9e2ec53) **Toast is in-front of blurred dialog background** ![image](https://github.com/documenso/documenso/assets/20962767/5ea35ec5-c825-4fa0-a4ee-54a86c8179cb) **Dropdown is no longer being cropped off** ![image](https://github.com/documenso/documenso/assets/20962767/f4d092b2-4083-49ea-bc70-6a82e5dd44e1) ## Checklist - [X] I have tested these changes locally and they work as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:11 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:18 +03:00

[PR #1181] [MERGED] chore: freelancer blog article #2 #1450

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1181

No description provided.

Rows
Columns