[PR #760] [MERGED] fix: trimmed long file names for better UX #1165

New issue

Closed

opened 2026-02-26 19:32:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/760
Author: @Mohith234
Created: 12/13/2023
Status: ✅ Merged
Merged: 12/29/2023
Merged by: @catalinpit

Base: main ← Head: fix/large-filenames

📝 Commits (6)

2ce1cc7 fix: trimmed long file names for better UX
22bcff4 refactor: abstracted truncateTitle function as a reusable function
e97aaa7 Merge branch 'main' into fix/large-filenames
ea80a29 Merge branch 'main' into fix/large-filenames
d531cb4 chore: truncate other titles
c005f8d chore: add default value

📊 Changes

4 files changed (+25 additions, -5 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/complete/page.tsx (+5 -1)
📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+5 -1)
📝 apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx (+5 -3)
➕ apps/web/src/helpers/truncate-title.ts (+10 -0)

📄 Description

Fixes #755

Notes for Reviewers

The max length of the title is set to be 16
If the length of the title is <16 it returns the original one.
Or else the title will be the first 8 characters (start) and last 8 characters (end)
The truncated file name will look like start...end

Screenshot for reference

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/760 **Author:** [@Mohith234](https://github.com/Mohith234) **Created:** 12/13/2023 **Status:** ✅ Merged **Merged:** 12/29/2023 **Merged by:** [@catalinpit](https://github.com/catalinpit) **Base:** `main` ← **Head:** `fix/large-filenames` --- ### 📝 Commits (6) - [`2ce1cc7`](https://github.com/documenso/documenso/commit/2ce1cc7ac9e487c1754dffcab9b9d35c6e4e81a3) fix: trimmed long file names for better UX - [`22bcff4`](https://github.com/documenso/documenso/commit/22bcff4108ad6e4a4ba1b03f20a412b70c595a5e) refactor: abstracted truncateTitle function as a reusable function - [`e97aaa7`](https://github.com/documenso/documenso/commit/e97aaa7e2939d7010a7fad40cdf6734a4fcfc369) Merge branch 'main' into fix/large-filenames - [`ea80a29`](https://github.com/documenso/documenso/commit/ea80a29c94ec679f1c3e3741b6fa9d0aa5c4002c) Merge branch 'main' into fix/large-filenames - [`d531cb4`](https://github.com/documenso/documenso/commit/d531cb4496c3f70d01bc1f21aecfe67f552da522) chore: truncate other titles - [`c005f8d`](https://github.com/documenso/documenso/commit/c005f8ded4a8a6b262120fae1942a97b8b2edc1d) chore: add default value ### 📊 Changes **4 files changed** (+25 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/complete/page.tsx` (+5 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+5 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx` (+5 -3) ➕ `apps/web/src/helpers/truncate-title.ts` (+10 -0) </details> ### 📄 Description Fixes #755 ### Notes for Reviewers - The max length of the title is set to be `16` - If the length of the title is <16 it returns the original one. - Or else the title will be the first 8 characters (start) and last 8 characters (end) - The truncated file name will look like `start...end` ### Screenshot for reference ![image](https://github.com/documenso/documenso/assets/88539464/565e4868-7bb1-4b46-9cb0-886d542b8a01) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:07 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:15 +03:00

[PR #1165] [MERGED] feat: add direct templates links #1438

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1165

No description provided.

Rows
Columns