[PR #740] [MERGED] refactor: download function to be reusable #1151

Closed
opened 2026-02-26 19:32:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/740
Author: @ephraimduncan
Created: 12/7/2023
Status: Merged
Merged: 1/18/2024
Merged by: @Mythie

Base: mainHead: refactor/download-function


📝 Commits (5)

  • 38ad3a1 refactor: download function to be reusable
  • b9282f1 Merge branch 'main' into refactor/download-function
  • b76d2ce fix: changes from code review
  • 6a26ab4 fix: toast import errors
  • 0d15b80 fix: simplify code

📊 Changes

7 files changed (+73 additions, -76 deletions)

View changed files

📝 .vscode/settings.json (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx (+5 -19)
📝 apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx (+28 -32)
packages/lib/client-only/download-pdf.ts (+29 -0)
📝 packages/prisma/types/document-with-data.ts (+1 -1)
📝 packages/ui/components/document/document-download-button.tsx (+8 -22)
📝 packages/ui/primitives/use-toast.ts (+1 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/740 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 12/7/2023 **Status:** ✅ Merged **Merged:** 1/18/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `refactor/download-function` --- ### 📝 Commits (5) - [`38ad3a1`](https://github.com/documenso/documenso/commit/38ad3a19229797de45591b7a4033e3cc530448f3) refactor: download function to be reusable - [`b9282f1`](https://github.com/documenso/documenso/commit/b9282f11b0a9cc64921d7999ae740dc0de07136e) Merge branch 'main' into refactor/download-function - [`b76d2ce`](https://github.com/documenso/documenso/commit/b76d2cea3be939805b1bf051d601708435a416eb) fix: changes from code review - [`6a26ab4`](https://github.com/documenso/documenso/commit/6a26ab4b2b8bcb23348e421d7dc6de7e6c08ff10) fix: toast import errors - [`0d15b80`](https://github.com/documenso/documenso/commit/0d15b80c2d6f001b01ec500c5433c5bd03b7ed17) fix: simplify code ### 📊 Changes **7 files changed** (+73 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `.vscode/settings.json` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx` (+5 -19) 📝 `apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx` (+28 -32) ➕ `packages/lib/client-only/download-pdf.ts` (+29 -0) 📝 `packages/prisma/types/document-with-data.ts` (+1 -1) 📝 `packages/ui/components/document/document-download-button.tsx` (+8 -22) 📝 `packages/ui/primitives/use-toast.ts` (+1 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:32:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1151
No description provided.