[PR #596] [CLOSED] fix: signer fields cannot be edited/removed after modifying the signer #1069

Closed
opened 2026-02-26 19:31:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/596
Author: @alfredlouisw8
Created: 10/26/2023
Status: Closed

Base: feat/refreshHead: fix-470-modified-signer-bug


📝 Commits (3)

  • 1bbbbac fix: signer fields cannot be edited/removed after modifying the signer
  • 3127bf0 fix: add types explicitly
  • f2ade4b Merge branch 'feat/refresh' into fix-470-modified-signer-bug

📊 Changes

3 files changed (+20 additions, -16 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+14 -14)
📝 apps/web/src/components/forms/edit-document/add-fields.action.ts (+3 -1)
📝 apps/web/src/components/forms/edit-document/add-signers.action.ts (+3 -1)

📄 Description

fixes: #470

The approach I use is using a state variable to store the recipients and signer so that it changes on every step

any feedback for the code is appreciated! :)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/596 **Author:** [@alfredlouisw8](https://github.com/alfredlouisw8) **Created:** 10/26/2023 **Status:** ❌ Closed **Base:** `feat/refresh` ← **Head:** `fix-470-modified-signer-bug` --- ### 📝 Commits (3) - [`1bbbbac`](https://github.com/documenso/documenso/commit/1bbbbacf4e20128ed112307a968f5c2c771a9489) fix: signer fields cannot be edited/removed after modifying the signer - [`3127bf0`](https://github.com/documenso/documenso/commit/3127bf01f790c576470bb95485003caebd35f349) fix: add types explicitly - [`f2ade4b`](https://github.com/documenso/documenso/commit/f2ade4b17430729979ce18345f04176bd3a775ab) Merge branch 'feat/refresh' into fix-470-modified-signer-bug ### 📊 Changes **3 files changed** (+20 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+14 -14) 📝 `apps/web/src/components/forms/edit-document/add-fields.action.ts` (+3 -1) 📝 `apps/web/src/components/forms/edit-document/add-signers.action.ts` (+3 -1) </details> ### 📄 Description fixes: #470 The approach I use is using a state variable to store the recipients and signer so that it changes on every step any feedback for the code is appreciated! :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:31:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1069
No description provided.