[PR #557] [MERGED] fix: fix for Accepting signatures or text fields with white space only #551 #1043

New issue

Closed

opened 2026-02-26 19:31:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:31:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/557
Author: @Abhinav-Developer-23
Created: 10/13/2023
Status: ✅ Merged
Merged: 10/16/2023
Merged by: @dguyen

Base: feat/refresh ← Head: white-space-validation-#551

📝 Commits (6)

59dc821 fix: fix for Accepting signatures or text fields with white space only in multiple places #551
7cf9134 fix: updated validation error messages
0b032e7 Merge remote-tracking branch 'origin/white-space-validation-#551' into white-space-validation-#551
1f7c889 Merge branch 'documenso:feat/refresh' into white-space-validation-#551
0c5635c fix: updated validation error messages
e29ee8a Merge remote-tracking branch 'origin/white-space-validation-#551' into white-space-validation-#551

📊 Changes

4 files changed (+5 additions, -5 deletions)

View changed files

📝 apps/marketing/src/components/(marketing)/claim-plan-dialog.tsx (+1 -1)
📝 apps/marketing/src/components/(marketing)/widget.tsx (+2 -2)
📝 apps/web/src/components/forms/profile.tsx (+1 -1)
📝 apps/web/src/components/forms/signup.tsx (+1 -1)

📄 Description

fixes #551
There are multiple places where text fields can be filled with white space only.
In this PR I have fixed on 4 pages. Please find the working demo video.

https://stg-marketing.documenso.com/ (both signature and name)
https://stg-marketing.documenso.com/pricing (when we click on signup now)
regular sign up page (http://localhost:3000/signup)
profile page (http://localhost:3000/settings/profile)

https://github.com/documenso/documenso/assets/145282438/58ec4dca-0bfc-44ed-95db-51fbbd0ab394

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/557 **Author:** [@Abhinav-Developer-23](https://github.com/Abhinav-Developer-23) **Created:** 10/13/2023 **Status:** ✅ Merged **Merged:** 10/16/2023 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `feat/refresh` ← **Head:** `white-space-validation-#551` --- ### 📝 Commits (6) - [`59dc821`](https://github.com/documenso/documenso/commit/59dc82160ace20738e827d7517efcfc81b680256) fix: fix for Accepting signatures or text fields with white space only in multiple places #551 - [`7cf9134`](https://github.com/documenso/documenso/commit/7cf913421eabb22b1fe2d00e20c41650fc41dfff) fix: updated validation error messages - [`0b032e7`](https://github.com/documenso/documenso/commit/0b032e7e08eaf1d6be0555ff9a41d7c0d93fbb86) Merge remote-tracking branch 'origin/white-space-validation-#551' into white-space-validation-#551 - [`1f7c889`](https://github.com/documenso/documenso/commit/1f7c8892fb65b220a47aeca1079d1575ccf995c7) Merge branch 'documenso:feat/refresh' into white-space-validation-#551 - [`0c5635c`](https://github.com/documenso/documenso/commit/0c5635c0096e9f015239b925d0db83806af54bb4) fix: updated validation error messages - [`e29ee8a`](https://github.com/documenso/documenso/commit/e29ee8a4980d9734787f756a0ebb02ed6a453a89) Merge remote-tracking branch 'origin/white-space-validation-#551' into white-space-validation-#551 ### 📊 Changes **4 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/src/components/(marketing)/claim-plan-dialog.tsx` (+1 -1) 📝 `apps/marketing/src/components/(marketing)/widget.tsx` (+2 -2) 📝 `apps/web/src/components/forms/profile.tsx` (+1 -1) 📝 `apps/web/src/components/forms/signup.tsx` (+1 -1) </details> ### 📄 Description fixes #551 There are multiple places where text fields can be filled with white space only. In this PR I have fixed on 4 pages. Please find the working demo video. https://stg-marketing.documenso.com/ (both signature and name) https://stg-marketing.documenso.com/pricing (when we click on signup now) regular sign up page (http://localhost:3000/signup) profile page (http://localhost:3000/settings/profile) https://github.com/documenso/documenso/assets/145282438/58ec4dca-0bfc-44ed-95db-51fbbd0ab394 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:31:35 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:32:50 +03:00

[PR #1043] [MERGED] chore: minor update to open page #1340

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1043

No description provided.

Rows
Columns