starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #486] [MERGED] feat: add safari clipboard copy support #1000

New issue

Closed

opened 2026-02-26 19:31:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:31:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/486
Author: @dguyen
Created: 10/2/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @dguyen

Base: feat/refresh ← Head: fix/467-bugsafari-only-unable-to-copy-document-sharing-link

📝 Commits (9)

6b801ff feat: add safari clipboard copy support
0d42285 Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link
4db98bc fix: add copy fallback
8cbc396 chore: update comments
732dc45 refactor: restructure logic
77ca7d7 Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link
569a559 Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link
24af839 refactor: extract toast
854eaa8 Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link

📊 Changes

8 files changed (+163 additions, -67 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx (+22 -22)
📝 apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx (+21 -22)
➕ packages/lib/client-only/hooks/use-copy-share-link.ts (+53 -0)
📝 packages/lib/client-only/hooks/use-copy-to-clipboard.ts (+36 -4)
➕ packages/lib/constants/toast.ts (+13 -0)
📝 packages/lib/server-only/user/delete-user.ts (+1 -1)
📝 packages/ui/components/document/document-share-button.tsx (+16 -17)
📝 packages/ui/primitives/use-toast.ts (+1 -1)

📄 Description

Fixes #467

Changes:

Added ClipboardItem to handle copying async values for Safari
Extracted useCopyToClipboard to @documenso/lib
Extracted duplicate logic for copying shared links to it's own hook

Tested on the following platforms:

MacOS:

Safari
Firefox
Chrome

iOS:

Safari

Ubuntu:

Chrome
Firefox

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/486 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 10/2/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `feat/refresh` ← **Head:** `fix/467-bugsafari-only-unable-to-copy-document-sharing-link` --- ### 📝 Commits (9) - [`6b801ff`](https://github.com/documenso/documenso/commit/6b801fff34a9418a8517353b0a39c1e60596f290) feat: add safari clipboard copy support - [`0d42285`](https://github.com/documenso/documenso/commit/0d42285f5dbad6c90bdfb4c13fb856da2fbde590) Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link - [`4db98bc`](https://github.com/documenso/documenso/commit/4db98bc19c16d18a048a1903289f90aa97427a77) fix: add copy fallback - [`8cbc396`](https://github.com/documenso/documenso/commit/8cbc396e2d28dca7d567153a0d8a0ceef8f8ae38) chore: update comments - [`732dc45`](https://github.com/documenso/documenso/commit/732dc45295afbd9d39329e8b4e0d7603daa5a3ea) refactor: restructure logic - [`77ca7d7`](https://github.com/documenso/documenso/commit/77ca7d70fef35efef624eb9221e75788566062d9) Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link - [`569a559`](https://github.com/documenso/documenso/commit/569a5598058654031bba5d39f4601319a3e57883) Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link - [`24af839`](https://github.com/documenso/documenso/commit/24af83923df4bdb7ed7b6efeb4a9d7336b7be8b7) refactor: extract toast - [`854eaa8`](https://github.com/documenso/documenso/commit/854eaa8049b0171d1f7491dd7be15a7904660fbe) Merge branch 'feat/refresh' into fix/467-bugsafari-only-unable-to-copy-document-sharing-link ### 📊 Changes **8 files changed** (+163 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx` (+22 -22) 📝 `apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx` (+21 -22) ➕ `packages/lib/client-only/hooks/use-copy-share-link.ts` (+53 -0) 📝 `packages/lib/client-only/hooks/use-copy-to-clipboard.ts` (+36 -4) ➕ `packages/lib/constants/toast.ts` (+13 -0) 📝 `packages/lib/server-only/user/delete-user.ts` (+1 -1) 📝 `packages/ui/components/document/document-share-button.tsx` (+16 -17) 📝 `packages/ui/primitives/use-toast.ts` (+1 -1) </details> ### 📄 Description Fixes #467 ## Changes: - Added `ClipboardItem` to handle copying async values for Safari - Extracted `useCopyToClipboard` to @documenso/lib - Extracted duplicate logic for copying shared links to it's own hook ## Tested on the following platforms: ### MacOS: - Safari - Firefox - Chrome ### iOS: - Safari ### Ubuntu: - Chrome - Firefox --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:31:23 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:32:43 +03:00

[PR #1000] [MERGED] fix: add seed script to dx setup #1311

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1000

No description provided.

Rows
Columns