starred/docker-test-openldap
1
0
Fork 0
mirror of https://github.com/rroemhild/docker-test-openldap.git synced 2026-04-25 15:15:53 +03:00
Code Issues 14 Projects Releases 3 Packages Wiki Activity

[GH-ISSUE #23] Fix listen address #12

New issue
Closed
opened 2026-02-27 16:47:38 +03:00 by kerem · 7 comments
kerem commented 2026-02-27 16:47:38 +03:00
Owner
Copy link

Originally created by @wollanup on GitHub (Jan 4, 2021).
Original GitHub issue: https://github.com/rroemhild/docker-test-openldap/issues/23

Please merge https://github.com/rroemhild/docker-test-openldap/pull/21 ASAP.

CI stages based on your latest image are broken, and we can't rollback, as only latest image is provided on DockerHub.

Thank you.

Originally created by @wollanup on GitHub (Jan 4, 2021). Original GitHub issue: https://github.com/rroemhild/docker-test-openldap/issues/23 Please merge https://github.com/rroemhild/docker-test-openldap/pull/21 ASAP. CI stages based on your latest image are broken, and we can't rollback, as only `latest` image is provided on DockerHub. Thank you.
kerem closed this issue 2026-02-27 16:47:39 +03:00
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@liorhasson commented on GitHub (Jan 4, 2021):

Our CI also broken!!!! ASAP
Also can you please publish docker tags for every release, then we can use specific version!

@rroemhild
Thanks

<!-- gh-comment-id:754025056 --> @liorhasson commented on GitHub (Jan 4, 2021): Our CI also broken!!!! ASAP Also can you please publish docker tags for every release, then we can use specific version! @rroemhild Thanks
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@rroemhild commented on GitHub (Jan 4, 2021):

Sorry folks! I've reverted the port changes too. Builds will be tagged in the future.

<!-- gh-comment-id:754031588 --> @rroemhild commented on GitHub (Jan 4, 2021): Sorry folks! I've reverted the port changes too. Builds will be tagged in the future.
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@wollanup commented on GitHub (Jan 4, 2021):

Thank you @rroemhild
Image tags would be great !
It was not a bad idea to use a port > 1024, maybe in a 2.0 tag as it's a breaking change ?

<!-- gh-comment-id:754036328 --> @wollanup commented on GitHub (Jan 4, 2021): Thank you @rroemhild Image tags would be great ! It was not a bad idea to use a port > 1024, maybe in a 2.0 tag as it's a breaking change ?
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@wollanup commented on GitHub (Jan 4, 2021):

Oh, I've just seen you change ports again a few seconds ago :D
So we keep unprivilegied ports 10XXX, which sounds logical.

<!-- gh-comment-id:754037107 --> @wollanup commented on GitHub (Jan 4, 2021): Oh, I've just seen you change ports again a few seconds ago :D So we keep unprivilegied ports `10XXX`, which sounds logical.
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@rroemhild commented on GitHub (Jan 4, 2021):

I've made it worse :D

I add the tag v1 to the latest commit/build before I've done major changes.

<!-- gh-comment-id:754038288 --> @rroemhild commented on GitHub (Jan 4, 2021): I've made it worse :D I add the tag `v1` to the latest commit/build before I've done major changes.
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@wollanup commented on GitHub (Jan 4, 2021):

OK, your latest commit sounds goot to me, with the new unprivilegied ports config 10389, my CI stage pass.

May I suggest you to publish docker image 2.0 and 1.0 (as a fallback) on DockerHub for folks who can't update their code/config ?

Maybe it's easier for some people to only add the target tag in a docker-compose file ?

<!-- gh-comment-id:754050089 --> @wollanup commented on GitHub (Jan 4, 2021): OK, your latest commit sounds goot to me, with the new unprivilegied ports config `10389`, my CI stage pass. May I suggest you to publish docker image `2.0` and `1.0` (as a fallback) on DockerHub for folks who can't update their code/config ? Maybe it's easier for some people to only add the target tag in a docker-compose file ?
kerem commented 2026-02-27 16:47:39 +03:00
Author
Owner
Copy link

@rroemhild commented on GitHub (Jan 4, 2021):

Great! Tags are now on DockerHub.

<!-- gh-comment-id:754069066 --> @rroemhild commented on GitHub (Jan 4, 2021): Great! Tags are now on DockerHub.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
revert-44-ship_crew_mail
v1.0
v2.5.0
v2.4.0
2.3
2.2
2.1
1.1
2.0
v1
1.0
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/docker-test-openldap#12
No description provided.