mirror of
https://github.com/netbootxyz/docker-netbootxyz.git
synced 2026-04-24 22:45:49 +03:00
[PR #57] [MERGED] Make web app port configurable. #76
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/docker-netbootxyz#76
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/57
Author: @CompPhy
Created: 2/2/2024
Status: ✅ Merged
Merged: 2/5/2024
Merged by: @antonym
Base:
master← Head:master📝 Commits (1)
c4014a0Make web app port configurable.📊 Changes
4 files changed (+8 additions, -4 deletions)
View changed files
📝
Dockerfile(+1 -0)📝
README.md(+3 -1)📝
docker-compose.yml.example(+3 -2)📝
root/etc/supervisor.conf(+1 -1)📄 Description
This PR adds WEB_APP_PORT environment variable, which is defaulted to port 3000 but can be overridden at deployment time.
Some platforms, like TrueNAS, want to bind web services to different ports; but also need to do this in the context where host networking is enabled for TFTP to work correctly. This means that services inside the container need to be more configurable on the network port binding.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.