mirror of
https://github.com/netbootxyz/docker-netbootxyz.git
synced 2026-04-24 22:45:49 +03:00
[PR #55] [MERGED] Replace in.tftp server with dnsmasq, to add support for single-port TFTP #74
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/docker-netbootxyz#74
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/55
Author: @dezeroku
Created: 1/31/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @antonym
Base:
master← Head:to-upstream📝 Commits (1)
fe00be3Replace in.tftp with dnsmasq, to add support for single-port TFTP📊 Changes
3 files changed (+4 additions, -3 deletions)
View changed files
📝
Dockerfile(+1 -1)📝
README.md(+1 -0)📝
root/etc/supervisor.conf(+2 -2)📄 Description
Dnsmasq provides TFTP server functionality that supports the optional
--tftp-single-portargument.Essentialy, when this flag is provided, all TFTP connections (not only the initial one) are performed over port
69.This makes it much easier to set up in environment with heavy NAT and/or firewall.
It comes in handy e.g. with the Kubernetes deployments.
Reasoning is basically the same as in parallel PR.
I've tested the changes in K8s environment (exposing only port 69 of the container) and with the example
docker-compose.yml, connecting from a VM and a "real" device.Also documenting the
TFTPD_OPTSenv variable.The
--port=0argument disables the built-in DNS server.Oh, and thanks for providing nice software!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.