[PR #54] [MERGED] Make nginx port configurable through ENV variable. #73

Closed
opened 2026-02-27 14:47:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/54
Author: @CompPhy
Created: 1/12/2024
Status: Merged
Merged: 1/19/2024
Merged by: @antonym

Base: masterHead: master


📝 Commits (1)

  • 959f24b Make nginx port configurable through ENV variable.

📊 Changes

5 files changed (+10 additions, -7 deletions)

View changed files

📝 Dockerfile (+2 -0)
📝 README.md (+2 -2)
📝 docker-compose.yml.example (+2 -1)
📝 root/defaults/default (+1 -1)
📝 root/start.sh (+3 -3)

📄 Description

Closes #53

I did build the image and run against a docker host to make sure these changes work.

Default is still port 80, but now it can be overriden with ENV variable when needed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/docker-netbootxyz/pull/54 **Author:** [@CompPhy](https://github.com/CompPhy) **Created:** 1/12/2024 **Status:** ✅ Merged **Merged:** 1/19/2024 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`959f24b`](https://github.com/netbootxyz/docker-netbootxyz/commit/959f24bc59fbda2b43a5399a666d75e06830b3f6) Make nginx port configurable through ENV variable. ### 📊 Changes **5 files changed** (+10 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+2 -0) 📝 `README.md` (+2 -2) 📝 `docker-compose.yml.example` (+2 -1) 📝 `root/defaults/default` (+1 -1) 📝 `root/start.sh` (+3 -3) </details> ### 📄 Description Closes #53 I did build the image and run against a docker host to make sure these changes work. Default is still port 80, but now it can be overriden with ENV variable when needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 14:47:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/docker-netbootxyz#73
No description provided.