mirror of
https://github.com/netbootxyz/docker-netbootxyz.git
synced 2026-04-24 22:45:49 +03:00
[PR #54] [MERGED] Make nginx port configurable through ENV variable. #73
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/docker-netbootxyz#73
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/54
Author: @CompPhy
Created: 1/12/2024
Status: ✅ Merged
Merged: 1/19/2024
Merged by: @antonym
Base:
master← Head:master📝 Commits (1)
959f24bMake nginx port configurable through ENV variable.📊 Changes
5 files changed (+10 additions, -7 deletions)
View changed files
📝
Dockerfile(+2 -0)📝
README.md(+2 -2)📝
docker-compose.yml.example(+2 -1)📝
root/defaults/default(+1 -1)📝
root/start.sh(+3 -3)📄 Description
Closes #53
I did build the image and run against a docker host to make sure these changes work.
Default is still port 80, but now it can be overriden with ENV variable when needed.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.