mirror of
https://github.com/netbootxyz/docker-netbootxyz.git
synced 2026-04-25 06:55:49 +03:00
[GH-ISSUE #69] Use nginx to redirect from local assets to the standard github live_endpoint #21
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/docker-netbootxyz#21
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sjuerges on GitHub (Aug 3, 2024).
Original GitHub issue: https://github.com/netbootxyz/docker-netbootxyz/issues/69
Is your feature request related to a problem? Please describe.
I want to keep a few things locally that get used very often, but I want to be able to try out everything else via the standard live_endpoint
Describe the solution you'd like
Well, I've built a solution and would like to suggest it here: I have modified the nginx config so that i reads as follows:
(code from serverfault i stumbled across some time ago and remembered for this: https://serverfault.com/questions/1099771/redirect-to-other-server-and-domain-if-file-not-found)
This lets me have my cake and eat it too. I can access stuff that isn't there locally, and the nginx sends a 302 to the "standard" live_endpoint url to the client, which then gets it there:
But, i can also access stuff that was downloaded:
Describe alternatives you've considered
I was messing about with caching and i found it ... tedious, to say the least. This is, imho, elegant, ties into the local asset management and SHOULDNT break anything.
Additional context
None. I think its fairly obvious what is happening here. Feel free to contact me for details if anything is unclear ;)
@sjuerges commented on GitHub (Aug 3, 2024):
Oh, I would've written a PR if I understood how the initial site-confs/default gets created :) Wasn't trying to be lazy.
@sjuerges commented on GitHub (Aug 3, 2024):
ah damn, this probably should've gone into docker-netbootxyz issues, right? Sorry, too excited, my bad.
@antonym commented on GitHub (Aug 3, 2024):
I can move it, if you want to propose a PR, I can find some time to test it out.
@sjuerges commented on GitHub (Aug 3, 2024):
I'll write a PR tomorrow, thanks @antonym