[PR #58] Add proxying to github for non-existing local assets #199

New issue

Open

opened 2026-03-01 18:33:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:33:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/58
Author: @worried-networking
Created: 2/19/2024
Status: 🔄 Open

Base: master ← Head: patch-1

📝 Commits (1)

0bdec08 Add proxying to github for non-existing local assets

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 root/defaults/default (+11 -0)

📄 Description

In the existing implementation, you need to cache all the possible assets locally, or you won't be able to use them. This PR adds a way for end-users to use locally cached assets and, at the same time, enjoy an occasional non-cached asset.

I'm unsure if including this change in the main docker image is worth it: adding a new docker tag for non-security cautious people/environments where this will be enabled might be a better idea. Or maybe setting up an nginx server on a different port just for that. Please advise how you would like to proceed here.

I'm using netboot.xyz in a tiny just-for-fun homelab environment, and I very much enjoy having a few most-used assets in the local cache and still being able to boot any other available thing :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/docker-netbootxyz/pull/58 **Author:** [@worried-networking](https://github.com/worried-networking) **Created:** 2/19/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`0bdec08`](https://github.com/netbootxyz/docker-netbootxyz/commit/0bdec080322dba2cbb1c3d88ed677a9b55686ac7) Add proxying to github for non-existing local assets ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `root/defaults/default` (+11 -0) </details> ### 📄 Description In the existing implementation, you need to cache all the possible assets locally, or you won't be able to use them. This PR adds a way for end-users to use locally cached assets and, at the same time, enjoy an occasional non-cached asset. I'm unsure if including this change in the main docker image is worth it: adding a new docker tag for non-security cautious people/environments where this will be enabled might be a better idea. Or maybe setting up an nginx server on a different port just for that. Please advise how you would like to proceed here. I'm using netboot.xyz in a tiny just-for-fun homelab environment, and I very much enjoy having a few most-used assets in the local cache and still being able to boot any other available thing :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>