starred/docker-netbootxyz
1
0
Fork 0
mirror of https://github.com/netbootxyz/docker-netbootxyz.git synced 2026-04-25 15:05:50 +03:00
Code Issues 58 Projects Releases Packages Wiki Activity

[PR #56] [MERGED] Separate init script from the start script #191

New issue
Closed
opened 2026-03-01 18:33:43 +03:00 by kerem · 0 comments
kerem commented 2026-03-01 18:33:43 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/56
Author: @dezeroku
Created: 1/31/2024
Status: ✅ Merged
Merged: 2/4/2024
Merged by: @antonym

Base: master ← Head: to-upstream-two

📝 Commits (1)

  • cdae9b6 Separate init script from the start script

📊 Changes

2 files changed (+78 additions, -74 deletions)

View changed files

➕ root/init.sh (+76 -0)
📝 root/start.sh (+2 -74)

📄 Description

In k8s environments it's quite common to bootstrap the deployments following these steps:

  1. Initialize the environment using upstream container
  2. Apply local customizations with a script
  3. Run the upstream container "as usual"

Currently there's no easy way to perform the initial configuration without starting the main processes, this PR separates "init" and "run" parts.

The init.sh file is basically copied as-is from the start.sh with two changes:

  1. removed the unnecessary backslash with a trailing space after then in line 30, as it was causing /start.sh: line 30: : not found warning/error
  2. wrapped echoed variable in double quotes in line 70

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/docker-netbootxyz/pull/56 **Author:** [@dezeroku](https://github.com/dezeroku) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 2/4/2024 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `master` ← **Head:** `to-upstream-two` --- ### 📝 Commits (1) - [`cdae9b6`](https://github.com/netbootxyz/docker-netbootxyz/commit/cdae9b68975826560cb2ccb9a4662aa2c66d01a2) Separate init script from the start script ### 📊 Changes **2 files changed** (+78 additions, -74 deletions) <details> <summary>View changed files</summary> ➕ `root/init.sh` (+76 -0) 📝 `root/start.sh` (+2 -74) </details> ### 📄 Description In k8s environments it's quite common to bootstrap the deployments following these steps: 1. Initialize the environment using upstream container 2. Apply local customizations with a script 3. Run the upstream container "as usual" Currently there's no easy way to perform the initial configuration without starting the main processes, this PR separates "init" and "run" parts. The `init.sh` file is basically copied as-is from the `start.sh` with two changes: 1. removed the unnecessary backslash with a trailing space after `then` in line 30, as it was causing `/start.sh: line 30: : not found` warning/error 2. wrapped echoed variable in double quotes in line 70 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 18:33:43 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
renovate/alpine-3.x
renovate/actions-github-script-9.x
feature/secureboot-support
ci/native-arm64-builds
ci-workflow-fix
0.7.6-nbxyz18
0.7.6-nbxyz17
0.7.6-nbxyz16
0.7.6-nbxyz13
0.7.6-nbxyz12
0.7.6-nbxyz11
0.7.6-nbxyz10
0.7.6-nbxyz9
0.7.6-nbxyz7
0.7.6-nbxyz6
0.7.6-nbxyz4
0.7.6-nbxyz3
0.7.6-nbxyz2
0.7.6-nbxyz1
0.7.5-nbxyz9
0.7.5-nbxyz8
0.7.5-nbxyz7
0.7.5-nbxyz6
0.7.5-nbxyz5
0.7.5-nbxyz4
0.7.5-nbxyz3
0.7.5-nbxyz2
0.7.4-nbxyz5
0.7.5-nbxyz1
0.7.4-nbxyz4
0.7.4-nbxyz3
0.7.4-nbxyz2
0.7.3-nbxyz5
0.7.4-nbxyz1
0.7.3-nbxyz4
0.7.3-nbxyz3
0.7.3-nbxyz2
0.7.1-nbxyz5
0.7.3-nbxyz1
0.7.2-nbxyz1
0.7.1-nbxyz4
0.7.1-nbxyz3
0.7.1-nbxyz2
0.7.1-nbxyz1
0.7.0-nbxyz6
0.7.0-nbxyz5
0.7.0-nbxyz4
0.7.0-nbxyz3
0.7.0-nbxyz2
0.7.0-nbxyz1
0.6.9-nbxyz2
0.6.9-nbxyz1
0.6.8-nbxyz6
0.6.8-nbxyz5
0.6.8-nbxyz4
0.6.8-nbxyz3
0.6.8-nbxyz2
0.6.8-nbxyz1
0.6.7-nbxyz31
0.6.7-nbxyz25
0.6.7-nbxyz24
0.6.7-nbxyz23
0.6.7-nbxyz22
0.6.7-nbxyz21
0.6.7-nbxyz20
0.6.7-nbxyz19
0.6.7-nbxyz18
0.6.7-nbxyz17
0.6.7-nbxyz16
0.6.7-nbxyz15
0.6.7-nbxyz14
0.6.7-nbxyz13
0.6.7-nbxyz12
0.6.7-nbxyz11
0.6.7-nbxyz10
0.6.7-nbxyz9
0.6.7-nbxyz8
0.6.7-nbxyz7
0.6.7-nbxyz6
0.6.7-nbxyz5
0.6.7-nbxyz4
0.6.7-nbxyz3
0.6.7-nbxyz2
0.6.7-nbxyz1
0.6.6-nbxyz15
0.6.6-nbxyz14
0.6.6-nbxyz13
0.6.6-nbxyz12
0.6.6-nbxyz11
0.6.6-nbxyz10
0.6.6-nbxyz9
0.6.6-nbxyz8
0.6.6-nbxyz7
0.6.6-nbxyz6
0.6.6-nbxyz4
0.6.6-nbxyz3
0.6.6-nbxyz2
0.6.6-nbxyz5
0.6.5-nbxyz5
0.6.6-nbxyz1
0.6.5-nbxyz4
0.6.5-nbxyz3
0.6.5-nbxyz2
0.6.5-nbxyz1
0.6.4-nbxyz13
0.6.4-nbxyz12
0.6.4-nbxyz11
0.6.4-nbxyz10
0.6.4-nbxyz9
0.6.4-nbxyz8
0.6.4-nbxyz7
0.6.4-nbxyz6
0.6.4-nbxyz5
0.6.4-nbxyz4
0.6.4-nbxyz3
0.6.4-nbxyz2
0.6.4-nbxyz1
Labels
Clear labels   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/docker-netbootxyz#191
No description provided.