[PR #108] consider environment variable SUBFOLDER in healthcheck.sh #113

New issue

Open

opened 2026-02-27 14:47:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 14:47:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/108
Author: @eagle-1
Created: 9/15/2025
Status: 🔄 Open

Base: master ← Head: fix-healthcheck-SUBFOLDER

📝 Commits (2)

fac089d consider environment variable SUBFOLDER in healthcheck.sh
bb82add Merge branch 'netbootxyz:master' into fix-healthcheck-SUBFOLDER

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 root/healthcheck.sh (+1 -1)

📄 Description

if we make use of environment variable SUBFOLDER in container deployment, container healthcheck never goes green because a wrong path will be checked.

Tested with:

    environment:
        - SUBFOLDER=/nbx/

if we use ${SUBFOLDER:-/} instead of a plain / in # Check Web App section, the healthcheck will succeed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/docker-netbootxyz/pull/108 **Author:** [@eagle-1](https://github.com/eagle-1) **Created:** 9/15/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-healthcheck-SUBFOLDER` --- ### 📝 Commits (2) - [`fac089d`](https://github.com/netbootxyz/docker-netbootxyz/commit/fac089dcb5fb1e9eb3205d33fb60319794cf1156) consider environment variable SUBFOLDER in healthcheck.sh - [`bb82add`](https://github.com/netbootxyz/docker-netbootxyz/commit/bb82add0f20e51a798483810bec53388390dee1c) Merge branch 'netbootxyz:master' into fix-healthcheck-SUBFOLDER ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `root/healthcheck.sh` (+1 -1) </details> ### 📄 Description if we make use of environment variable SUBFOLDER in container deployment, container healthcheck never goes green because a wrong path will be checked. Tested with: ```yaml environment: - SUBFOLDER=/nbx/ ``` if we use `${SUBFOLDER:-/}` instead of a plain `/` in `# Check Web App` section, the healthcheck will succeed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>