[PR #89] [MERGED] Fix CI build failure in release workflow #101

New issue

Closed

opened 2026-02-27 14:47:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 14:47:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/docker-netbootxyz/pull/89
Author: @antonym
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/12/2025
Merged by: @antonym

Base: master ← Head: ci-workflow-fix

📝 Commits (1)

d7cda28 Fix CI build failure in release workflow

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 .github/workflows/release.yml (+2 -1)

📄 Description

Summary

Added fetch-tags: true to checkout action to ensure git tags are available during CI runs
Added error handling to git rev-list command to prevent script failure when referenced tag doesn't exist

Problem

The release workflow was failing with exit code 129 on the git rev-list command when trying to find commit SHA for version tags that weren't available in the CI environment.

Solution

Fetch tags explicitly: Added fetch-tags: true to the checkout action to ensure all git tags are downloaded
Error handling: Modified the git rev-list command to gracefully handle missing tags by returning empty string instead of failing

Test plan

Verified the workflow syntax is correct
Confirmed the error handling works locally
Test in CI environment to ensure the build completes successfully

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/docker-netbootxyz/pull/89 **Author:** [@antonym](https://github.com/antonym) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/12/2025 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `master` ← **Head:** `ci-workflow-fix` --- ### 📝 Commits (1) - [`d7cda28`](https://github.com/netbootxyz/docker-netbootxyz/commit/d7cda284d961bef40d73117b3fe187699cde75db) Fix CI build failure in release workflow ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+2 -1) </details> ### 📄 Description ## Summary - Added `fetch-tags: true` to checkout action to ensure git tags are available during CI runs - Added error handling to `git rev-list` command to prevent script failure when referenced tag doesn't exist ## Problem The release workflow was failing with exit code 129 on the `git rev-list` command when trying to find commit SHA for version tags that weren't available in the CI environment. ## Solution 1. **Fetch tags explicitly**: Added `fetch-tags: true` to the checkout action to ensure all git tags are downloaded 2. **Error handling**: Modified the `git rev-list` command to gracefully handle missing tags by returning empty string instead of failing ## Test plan - [x] Verified the workflow syntax is correct - [x] Confirmed the error handling works locally - [ ] Test in CI environment to ensure the build completes successfully --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>