mirror of
https://github.com/hwdsl2/docker-ipsec-vpn-server.git
synced 2026-04-26 10:05:48 +03:00
[GH-ISSUE #98] Tags for Older Version #85
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pogzie on GitHub (Nov 12, 2018).
Original GitHub issue: https://github.com/hwdsl2/docker-ipsec-vpn-server/issues/98
Hi, since I was having problems with the new build, I was checking if there were other older versions available in Dockerhub, but all I see is the latest version.
Possible to keep the old releases for when the new version fails to work properly?
@selim13 commented on GitHub (Jan 22, 2019):
Not sure why this issue was closed.
It would be really nice to see proper tagging/versioning of the image.
@hwdsl2 commented on GitHub (Jan 22, 2019):
@selim13 Thanks for the suggestion. What is your use case for tagging this image? And what would you suggest that the tags are based on? Libreswan versions?
@selim13 commented on GitHub (Jan 22, 2019):
It's a good practice to keep image version pinned inside docker-compose file to prevent things breaking on images pulls. Also with github tagging/releases it is easier to keep track on source changes between them (especially on "sensitive" type of image like vpn). And it is simple to setup automated builds from those tags.
I would suggest libreswan version + numeric postfix like "3.27-1" as there is more interest on versioning image build scripts aside from libreswan.
Thanks for your time and this handy image =)
@rasodu commented on GitHub (Jul 27, 2020):
Not sure how much complexity it would add to current build process, but having tags have a few advantages.
@hwdsl2 commented on GitHub (Jul 27, 2020):
@rasodu Thank you for the suggestions. I agree that using tags may be beneficial in certain cases. However, for this particular Docker image, the testing in pre-production and/or rollback scenarios may not apply. And backward incompatible changes have been very rare in the history of this project. If you have examples of specific commit(s) which broke backward compatibility or could otherwise benefit from the use of tags, let me know.