mirror of
https://github.com/budtmo/docker-android.git
synced 2026-04-25 12:15:52 +03:00
[GH-ISSUE #4] Emulator doesn't manage to boot in time in case of CI scenarios #3
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/docker-android#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @andrcuns on GitHub (May 15, 2017).
Original GitHub issue: https://github.com/budtmo/docker-android/issues/4
In case if this container is used in some sort of CI setup for automated test execution, tests start executing before the android in emulator is actually booted up.
It is possible to delay test execution within test set up it self but would not be so convenient if deploying multiple containers with selenium grid via docker-compose for example.
Would You consider adding a check for avd boot_complete during container start?
@elgalu commented on GitHub (May 15, 2017):
SGTM 👍 What I do in docker-selenium is to
This will active wait up to 10 seconds for the container to be ready for tests but will finish as soon as is ready. This script can also be used as a HEALTHCHECK instruction.
So you guys could do something similar for this image, e.g.
And inside that
healthcheck.shyou put all the logic to wait for what's needed, avd boot_complete and so on.So users can be sure that after that the container is ready to be used for testing.
@budtmo commented on GitHub (May 15, 2017):
could you maybe help me to fix this issue? @andrcuns
@andrcuns commented on GitHub (May 15, 2017):
I have some ideas based on @elgalu excellent suggestion. I will try to test it out :)
@budtmo commented on GitHub (May 19, 2017):
I will close this PR, I have already included the implementation in release 0.5