[PR #48] [MERGED] Use px font sizing #53

New issue

Closed

opened 2026-02-27 23:20:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:20:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spatie/dnsrecords.io/pull/48
Author: @sebastiandedeyne
Created: 1/8/2019
Status: ✅ Merged
Merged: 1/18/2019
Merged by: @sebastiandedeyne

Base: master ← Head: use-px-font-sizing

📝 Commits (2)

8845294 Update deps
e29ba26 Use px font sizing

📊 Changes

2 files changed (+4521 additions, -1480 deletions)

View changed files

📝 resources/css/base/html.css (+36 -5)
📝 yarn.lock (+4485 -1475)

📄 Description

Unfortunately, viewport font sizes don't play well with browser zooming. For better accessability and usability, I think we should just use pixels instead.

See https://www.stefanjudis.com/today-i-learned/viewport-units-for-font-sizes-destroy-zooming/

We could do something "smarter", but I kinda like the simple solution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spatie/dnsrecords.io/pull/48 **Author:** [@sebastiandedeyne](https://github.com/sebastiandedeyne) **Created:** 1/8/2019 **Status:** ✅ Merged **Merged:** 1/18/2019 **Merged by:** [@sebastiandedeyne](https://github.com/sebastiandedeyne) **Base:** `master` ← **Head:** `use-px-font-sizing` --- ### 📝 Commits (2) - [`8845294`](https://github.com/spatie/dnsrecords.io/commit/88452942d2ec40c43899ef5390e4daca312a17f2) Update deps - [`e29ba26`](https://github.com/spatie/dnsrecords.io/commit/e29ba265c355de4cd37e7835599ad9a88f1431fd) Use px font sizing ### 📊 Changes **2 files changed** (+4521 additions, -1480 deletions) <details> <summary>View changed files</summary> 📝 `resources/css/base/html.css` (+36 -5) 📝 `yarn.lock` (+4485 -1475) </details> ### 📄 Description Unfortunately, viewport font sizes don't play well with browser zooming. For better accessability and usability, I think we should just use pixels instead. See https://www.stefanjudis.com/today-i-learned/viewport-units-for-font-sizes-destroy-zooming/ We could do something "smarter", but I kinda like the simple solution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>