[PR #46] [CLOSED] Fix for double encoding issue; #44 #51

New issue

Closed

opened 2026-02-27 23:20:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:20:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spatie/dnsrecords.io/pull/46
Author: @jryd
Created: 9/28/2018
Status: ❌ Closed

Base: master ← Head: double_encoding_issue

📝 Commits (1)

36dbba9 fix issue #44

📊 Changes

3 files changed (+2588 additions, -2559 deletions)

View changed files

📝 app/Services/Commands/Commands/DnsLookup.php (+2 -1)
📝 package-lock.json (+2579 -2558)
📝 tests/Feature/DnsLookupTest.php (+7 -0)

📄 Description

When a DNS record contained any quotes, these were being encoded by htmlentities() inside app/Services/Commands/Commands/DNSLookup.php on line 39.

We just needed to add the ENT_NOQUTOES flag.

Disclaimer; I am running a Windows machine that does not have the dig command, so I couldn't 100% verify this though. Regardless, I've written a test that should cover this. Would appreciate it if someone could verify this fix. If needed, I'll spin this up on my server to confirm its fixed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spatie/dnsrecords.io/pull/46 **Author:** [@jryd](https://github.com/jryd) **Created:** 9/28/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `double_encoding_issue` --- ### 📝 Commits (1) - [`36dbba9`](https://github.com/spatie/dnsrecords.io/commit/36dbba9713afedbb3dd9467f0c35481ab69c102b) fix issue #44 ### 📊 Changes **3 files changed** (+2588 additions, -2559 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Commands/Commands/DnsLookup.php` (+2 -1) 📝 `package-lock.json` (+2579 -2558) 📝 `tests/Feature/DnsLookupTest.php` (+7 -0) </details> ### 📄 Description When a DNS record contained any quotes, these were being encoded by `htmlentities()` inside `app/Services/Commands/Commands/DNSLookup.php` on line 39. We just needed to add the `ENT_NOQUTOES` flag. Disclaimer; I am running a Windows machine that does not have the `dig` command, so I couldn't 100% verify this though. Regardless, I've written a test that should cover this. Would appreciate it if someone could verify this fix. If needed, I'll spin this up on my server to confirm its fixed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>