[PR #2] [MERGED] many improvements: #5

New issue

Closed

opened 2026-03-15 16:04:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 16:04:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fortio/dnsping/pull/2
Author: @ldemailly
Created: 10/21/2020
Status: ✅ Merged
Merged: 10/21/2020
Merged by: @ldemailly

Base: main ← Head: pr2

📝 Commits (1)

2a8acbb many improvements:

📊 Changes

2 files changed (+84 additions, -35 deletions)

View changed files

📝 README.md (+44 -21)
📝 main.go (+40 -14)

📄 Description

shorter/better log output (without debug file/linenumber...)
show valid query types and accept them in lower case, use -q for query like nslookup so -t can be used for timeout
new -t timeout, lowered default to 700ms from 2s (so errors can be caught up and still do the default 1 ping per second even if continuously erring out)
use the lib client to be able to set timeout and get rtt from there
refactor shared format string between good and error cases
auto add missing trailing . to query (fully qualified domains, no search)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fortio/dnsping/pull/2 **Author:** [@ldemailly](https://github.com/ldemailly) **Created:** 10/21/2020 **Status:** ✅ Merged **Merged:** 10/21/2020 **Merged by:** [@ldemailly](https://github.com/ldemailly) **Base:** `main` ← **Head:** `pr2` --- ### 📝 Commits (1) - [`2a8acbb`](https://github.com/fortio/dnsping/commit/2a8acbbe3889acf761c85c80554b87e0d4565d45) many improvements: ### 📊 Changes **2 files changed** (+84 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+44 -21) 📝 `main.go` (+40 -14) </details> ### 📄 Description - shorter/better log output (without debug file/linenumber...) - show valid query types and accept them in lower case, use -q for query like `nslookup` so -t can be used for timeout - new -t timeout, lowered default to 700ms from 2s (so errors can be caught up and still do the default 1 ping per second even if continuously erring out) - use the lib client to be able to set timeout and get rtt from there - refactor shared format string between good and error cases - auto add missing trailing . to query (fully qualified domains, no search) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>